Skip to content
This repository was archived by the owner on May 28, 2018. It is now read-only.

Conversation

@oscarguindzberg
Copy link
Contributor

There is a bug when a validation fails for a primitive data array.
Eg a NotNull failed validation on a byte[] caused the code to throw a ClassCastException

@jerseyrobot
Copy link
Contributor

Can one of the admins verify this patch?

@AdamLindenthal
Copy link
Member

Jenkins, please test this patch.

@AdamLindenthal
Copy link
Member

Hi, thanks for your contribution.

Before we can review your pull request, we need you to sign Oracle Contributor Agreement.

More information about contributing to Jersey: https://jersey.java.net/scm.html#/Submitting_Patches_and_Contribute_Code

@AdamLindenthal
Copy link
Member

Actually, we also need an issue to be opened in our bug tracker. The JIRA issue describing a bug or justifying an improvement should be linked to every pull request. Could you please go through that as well? I know it's lot to do for the first time, but it gets more straightforward once you do it more often.

Thanks,
Adam

@oscarguindzberg
Copy link
Contributor Author

I sent the signed agreement, created issue JERSEY-2689 and added a unit test to reproduce the fixed issue

@AdamLindenthal
Copy link
Member

Thanks, now we have to wait a bit, until your name appears on the official list. Thanks.

@AdamLindenthal
Copy link
Member

Jenkins, please test this patch.

@AdamLindenthal
Copy link
Member

Hi Oscar,

the failed build does not seem to be related to your commit, at least not on the first sight. I will try to relaunch the build.

Adam

@AdamLindenthal
Copy link
Member

Jenkins, please test this patch.

@AdamLindenthal
Copy link
Member

Hi Oscar,
overall the pull request looks OK to me, I would just like to ask you to change the copyright headers. For the new files you created, the year should be 2014 (not 2012-2014 or similar). And the year in the web.xml is now 2012, while it should be 2014.

Thanks,
Adam

@oscarguindzberg
Copy link
Contributor Author

copyright updated

@AdamLindenthal
Copy link
Member

Verified manually, builds fine.

@AdamLindenthal
Copy link
Member

Jenkins, please test this patch.

@AdamLindenthal
Copy link
Member

Hi Oscar, now that we have a working Jenkins instance again, I just triggered the build to re-verify everything (there are some additional checks that I did not perform during my local verification).

@AdamLindenthal
Copy link
Member

Hi Oscar, now that we have a working Jenkins instance again, I just triggered the build to re-verify everything (there are some additional checks that I did not perform during my local verification).

Regards,
Adam

AdamLindenthal pushed a commit that referenced this pull request Dec 21, 2014
Deal with primitive array types
@AdamLindenthal AdamLindenthal merged commit 5976f56 into javaee:master Dec 21, 2014
@AdamLindenthal
Copy link
Member

Hi Oscar, just merged your PR, thank you for your contribution.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants