-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Deal with primitive array types #119
Conversation
|
Can one of the admins verify this patch? |
|
Jenkins, please test this patch. |
|
Hi, thanks for your contribution. Before we can review your pull request, we need you to sign Oracle Contributor Agreement. More information about contributing to Jersey: https://jersey.java.net/scm.html#/Submitting_Patches_and_Contribute_Code |
|
Actually, we also need an issue to be opened in our bug tracker. The JIRA issue describing a bug or justifying an improvement should be linked to every pull request. Could you please go through that as well? I know it's lot to do for the first time, but it gets more straightforward once you do it more often. Thanks, |
|
I sent the signed agreement, created issue JERSEY-2689 and added a unit test to reproduce the fixed issue |
|
Thanks, now we have to wait a bit, until your name appears on the official list. Thanks. |
|
Jenkins, please test this patch. |
|
Hi Oscar, the failed build does not seem to be related to your commit, at least not on the first sight. I will try to relaunch the build. Adam |
|
Jenkins, please test this patch. |
|
Hi Oscar, Thanks, |
|
copyright updated |
|
Verified manually, builds fine. |
|
Jenkins, please test this patch. |
|
Hi Oscar, now that we have a working Jenkins instance again, I just triggered the build to re-verify everything (there are some additional checks that I did not perform during my local verification). |
|
Hi Oscar, now that we have a working Jenkins instance again, I just triggered the build to re-verify everything (there are some additional checks that I did not perform during my local verification). Regards, |
Deal with primitive array types
|
Hi Oscar, just merged your PR, thank you for your contribution. |
There is a bug when a validation fails for a primitive data array.
Eg a NotNull failed validation on a byte[] caused the code to throw a ClassCastException