Skip to content
This repository was archived by the owner on May 28, 2018. It is now read-only.

Conversation

@lasselasse
Copy link
Contributor

This change fixes a known Moxy issue which has unfortunately been unresolved since July 2013: https://bugs.eclipse.org/bugs/show_bug.cgi?id=413809

@jerseyrobot
Copy link
Contributor

Can one of the admins verify this patch?

@AdamLindenthal
Copy link
Member

Jenkins, please test this patch.

@AdamLindenthal
Copy link
Member

Hi Lasse,
many thanks for your contribution.

Before we can review your pull request, we need you to sign Oracle Contributor Agreement.
Please note, that it takes a while until the OCA is officially approved and listed on the page linked above (which is a relevant list for us).

Also, I know, that there is already a moxy issue opened, but we tend to apply a rule, that every pull request should have an issue opened in our bugtracker, ideally mutually linked from github to JIRA and vice versa.

More information about contributing to Jersey: https://jersey.java.net/scm.html#/Submitting_Patches_and_Contribute_Code

Thanks,
Adam

@lasselasse
Copy link
Contributor Author

I have just submitted the signed OCA and created a Jersey issue: https://java.net/jira/browse/JERSEY-2758

@shamoh
Copy link
Contributor

shamoh commented Jan 19, 2015

Thanks a lot.

May you also add simple unit test to https://github.com/jersey/jersey/blob/master/tests/e2e/src/test/java/org/glassfish/jersey/tests/e2e/entity/JsonMoxyTest.java class to proof the fix? Thanks.

@shamoh
Copy link
Contributor

shamoh commented Jan 27, 2015

Signed OCA has been confirmed, thanks.
Dear Universe, add to whitelist Mr. Lasse.

@mgajdos mgajdos self-assigned this Feb 3, 2015
@mgajdos
Copy link
Contributor

mgajdos commented Feb 9, 2015

I am going to merge this pull request but it'll be reverted once MOXy 2.6 with the "real" fix is released and integrated into Jersey.

mgajdos added a commit that referenced this pull request Feb 9, 2015
Add support for nested generics to ConfigurableMoxyJsonProvider
@mgajdos mgajdos merged commit 9a60c00 into javaee:master Feb 9, 2015
@lasselasse
Copy link
Contributor Author

Thanks @mgajdos I just saw that the issue has been addressed in MOXy just now, which of course will be the best solution onc eit has been realeased.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants