This repository was archived by the owner on May 28, 2018. It is now read-only.
Restore JarFileScanner support for parents with a trailing slash #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Can one of the admins verify this patch? |
Contributor
|
Jenkins, test this patch. |
Contributor
Author
|
Hmm, the Jenkins build failed due to a test timeout. Earlier builds failed for the same reason, so I assume this is unrelated. (Locally the whole build ran just fine.) |
Contributor
|
Yeah, not caused by your change. This test sometimes fails on CloudBees. I'll verify this manually. |
Contributor
|
Verified manually. |
mgajdos
added a commit
that referenced
this pull request
Feb 26, 2015
…ailing-slash-fix Restore JarFileScanner support for parents with a trailing slash
Contributor
|
Thanks for fixing the issue. |
Contributor
Author
|
No problem, you're welcome. Thanks for merging it :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up of #132. In that ticket @cguillot pointed out that as a side effect of the solution to #132, the
parentparameter toJarFileScannermay no longer have a trailing slash. Since theparentparameter is clearly meant to be interpreted as a path component, I agree with @cguillot that this is a regression worth fixing.This PR restores support for trailing slashes and adds two unit tests to prove it. As a side effect the
JarFileScannerlogic actually became quite a bit simpler.As it stands, this PR introduces a small piece of conditional logic in the
JarFileScannerconstructor. If you prefer, I can also push this down into#hasNext()(at probably negligible performance cost).