This repository was archived by the owner on May 28, 2018. It is now read-only.
JERSEY-2837: Correctly handle negative byte values #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Can one of the admins verify this patch? |
Collaborator
|
Jenkins, please test this patch. |
Author
|
Merge looks OK but it failed to build. Could you please help verify? |
Author
|
Please merge the pull request. |
Contributor
|
Hi @luengnat, Before we can review your pull request, we need you to sign Oracle Contributor Agreement. More information about contributing to Jersey: https://jersey.java.net/scm.html#/Submitting_Patches_and_Contribute_Code… Regards, |
Contributor
|
You're right. The verification job failure is not related to your change. |
mpotociar
added a commit
that referenced
this pull request
Apr 17, 2015
JERSEY-2837: Correctly handle negative byte values
This was referenced Apr 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to https://java.net/jira/browse/JERSEY-2837
There is a bug in handling byte stream that contains 0xFF byte. When it does, it will treat the byte as EOF marker instead. This is due to mishandling of negative byte values.
I also refactored the code to reuse the same logic for both blocking and non-blocking cases