This repository was archived by the owner on May 28, 2018. It is now read-only.
JERSEY-2891: ExceptionMapper not chosen correctly in case of multiple ExtendedExceptionMappers with same generic type #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ltiple ExtendedExceptionMappers with same generic type
|
Can one of the admins verify this patch? |
|
Jenkins, please test this patch. |
There was a problem hiding this comment.
Missing copyright header. Please use a header e.g. from here: https://github.com/jersey/jersey/blob/master/core-common/src/test/java/org/glassfish/jersey/process/internal/ExecutorProvidersTest.java
…ator configured with binder
|
Verified manually. |
mgajdos
added a commit
that referenced
this pull request
Jun 24, 2015
JERSEY-2891: ExceptionMapper not chosen correctly in case of multiple ExtendedExceptionMappers with same generic type
|
Thanks for your contribution. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation ExceptionMapperFactory#find method used sorted map to store the mappers by distance of the generic exception type from the actual type. If there were two exception mappers with the same generic type, the mappers got overwritten in that map. Also I noticed that the exception mappers order was changing with server restart making the behavior unpredictable.
This fix removed the sorted map, finds the mapper with the lowest distance doing the 'isMappable' check within the same loop.