Problem with non utf-8 charset for a soap message with no xml declaration.

[glassfishrobot]

When soap requests are encoded using ISO-8859-1 (the http content-type header
reflects that) and there is no xml declaration it results in the following error:

ERROR: 'Invalid byte 2 of 3-byte UTF-8 sequence.'

I am using the Spring WS framework, which actually picks up on the charset
encoding and sets the SOAPPartImpl sourceCharsetEncoding appropriately.

However, as Spring WS holds the transformation Source in a JAXMStreamSource it
gets converted to a SAX InputSource before being wrapped in a SAXSource. The
InputSource is not advised of the correct charset encoding, so it gets lost -
resulting in the exception being thrown.

The JavaDoc for InputSource states that setEncoding should be used when the
application is aware of the encoding. In this case it is.

So, I propose that in EnvelopeFactory.createEnvelope(), after the InputSource
gets created, a line is added where the encoding is set to the SOAPPartImpl
sourceCharsetEncoding

btw. at present this is a showstopper for me - does anyone hava a workaround?

Environment

Operating System: All
Platform: All

Affected Versions

[current]

[glassfishrobot]

Reported by marinoj

[glassfishrobot]

Was assigned to saaj-issues

[glassfishrobot]

marinoj said:
I checked out the source and rolled my own joint - adding a
getSourceCharsetEncoding() to SOAPPartImpl and using it on
InputSource.setEncoding() right after the InputSource is instantiated. So this
is no longer a problem for me - but I'd rather be using the official version

[glassfishrobot]

rameshm said:
User already found out workaround, so downgrading the bug to P3.

[glassfishrobot]

@vbkumarjayanti said:
Thanks for filing the issue.

Since i do not have a testcase can you help me understand if the following is
the correct fix in EnvelopeFactory.createEnvelope()

InputSource is = SAXSource.sourceToInputSource(src);
if (is.getEncoding()== null && soapPart.sourceCharsetEncoding != null)

{ is.setEncoding(soapPart.sourceCharsetEncoding); }

[glassfishrobot]

marinoj said:
That's pretty much how I did it ... except I created a getter for
sourceCharsetEncoding

[glassfishrobot]

@vbkumarjayanti said:
Thanks,

I have made a fix and i believe the latest build is available at :

https://saaj.dev.java.net/servlets/ProjectDocumentList?folderID=5118&expandFolder=5118&folderID=5118

Can you download and confirm if it works for you. I can then close the issue.

[glassfishrobot]

marinoj said:
confirmed

you can close the issue.

thanks for the quick response!!

[glassfishrobot]

Marked as fixed on Monday, July 23rd 2007, 11:12:30 pm

[glassfishrobot]

This issue was imported from java.net JIRA SAAJ-25