[PORT 2.2]JAVASERVERFACES-3531 didn't correct all uses of getExternalContext().isSecure()

[javaserverfaces]

It seems that the fix applied in #3535 didn't correct all uses of getExternalContext().isSecure(). In particular, it's still called from elsewhere in ELFlash#setCookie [1].

Please fix the bug, because a Red Hat customer needs this issue to be resolved.

[1] https://github.com/jboss/mojarra/blob/8111d0950fa9a1bb2e48934bae76a466f474b552/jsf-ri/src/main/java/com/sun/faces/context/flash/ELFlash.java#L1002

Affected Versions

[2.1.29]

[javaserverfaces]

Reported by ivassile

[javaserverfaces]

Issue-Links:
clones
JAVASERVERFACES-4074

[javaserverfaces]

Was assigned to ren.zhijun.oracle

[javaserverfaces]

This issue was imported from java.net JIRA JAVASERVERFACES-4101

[xinyuan-zhang]

applied to 2.2.x: de71ab8
[port 2.2.x] JAVASERVERFACES-3531 didn't correct all uses of getExternalContext().isSecure()
https://github.com/javaserverfaces/mojarra/issues/4105

modified:   jsf-ri/src/main/java/com/sun/faces/context/flash/ELFlash.java