Why support #176
Merged
Why support #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keastrid
commented
Mar 24, 2022
Collaborator
|
There are some other issues opened ... when solved, I'll release your changes in JavaPackager 1.6.6. |
Contributor
Author
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name is unintentionally hilariousCloses #173
Draft as this is the bare minimum to get it to work (eg. assumes classpath is properly set in the main jar's manifest, mostly because I don't understand VTL), and doesn't expose any of the Why specific settings. Feel free to yoink whatever from it.
I would also like to get in the user-override for a given exe.
Currently uses Why 0.2.2.
Only tested with AstroImageJ so far.