Skip to content

Shadow Dom#317

Merged
mahdyar merged 9 commits intojavascript-tutorial:masterfrom
alas1n:Shadow-Dom
Feb 1, 2024
Merged

Shadow Dom#317
mahdyar merged 9 commits intojavascript-tutorial:masterfrom
alas1n:Shadow-Dom

Conversation

@alas1n
Copy link
Copy Markdown
Contributor

@alas1n alas1n commented Jan 16, 2024

اضافه کردن
Shadow DOM

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jan 16, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Copy Markdown
Member

@mahdyar mahdyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

سلام، مرسی از مشارکتتون.
لطف کنید قبل از بررسی کامل، خودتون ترجمه رو بررسی کنید و یک ترجمه روون و مطابق با راهنمای ترجمه (readme و ایشو) بدید. همچنین می‌تونید PRهای قبلی رو مشاهده کنید و مطابق اونا انجام بدید.

تعداد خط‌ها هم بررسی کنید و ترجمهٔ هر خط باید دقیقا داخل همون خط باشه.

مرسی.

@javascript-translate-bot
Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@alas1n
Copy link
Copy Markdown
Contributor Author

alas1n commented Jan 25, 2024

@mahdyar

با تشکر feedback
ترجمه خط به خط اضافه شد

/done

Comment on lines 29 to 33
/* رنگ ریل را به قرمز تغییر می‌دهد */
input::-webkit-slider-runnable-track {
background: red;
}
</style>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use formatters, remove the extra spaces.

@javascript-translate-bot
Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@alas1n
Copy link
Copy Markdown
Contributor Author

alas1n commented Jan 29, 2024

فرمتر اصلاح شد
/done

Copy link
Copy Markdown
Member

@mahdyar mahdyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also replace سایه with shadow anywhere you used it. It shouldn't get translated.

Copy link
Copy Markdown
Member

@mahdyar mahdyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also replace سایه with shadow anywhere you used it. It shouldn't get translated.

@javascript-translate-bot
Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@alas1n
Copy link
Copy Markdown
Contributor Author

alas1n commented Jan 31, 2024

سایه به shadow
روشن به light
درخت به tree
بازگردانی شد

/done

Copy link
Copy Markdown
Member

@mahdyar mahdyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @alas1n!

@mahdyar mahdyar merged commit 17d18bf into javascript-tutorial:master Feb 1, 2024
@alas1n alas1n deleted the Shadow-Dom branch February 2, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants