Skip to content

typeof - разъяснение #1837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Alexandre887 merged 10 commits into from
Apr 15, 2023
Merged

typeof - разъяснение #1837

Alexandre887 merged 10 commits into from
Apr 15, 2023

Conversation

@sias32
Copy link
Contributor

@sias32 sias32 commented Apr 14, 2023 •
edited
Loading

Немного вводите в заблуждение по поводу написания выражения в typeof. Предлагаю внести ясность.
Часть взято из MDN Mozilla

@sias32
typeof - разъяснение
56dc84a 
Немного вводите в заблуждение по поводу написания выражения в typeof. Предлагаю внести ясность
@javascript-translate-bot javascript-translate-bot added the review needed Review needed, please approve or request changes label Apr 14, 2023
@javascript-translate-bot javascript-translate-bot requested a review from a team April 14, 2023 10:20
@CLAassistant
Copy link

CLAassistant commented Apr 14, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

sias32 added 2 commits April 14, 2023 13:43
@sias32
Исправления
4b0449d 
Добавил информацию, про выражения
@sias32
Улучшения
e0dbdfa 
Улучшения по рекомендациям
Alexandre887
Alexandre887 requested changes Apr 14, 2023
View reviewed changes
Copy link
Member

@Alexandre887 Alexandre887 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Добрый вечер.
Правки действительно имеют место быть, сделал несколько исправлений.
Также в начале, где вы сравниваете typeof 5 и typeof(5), не помешало бы добавить небольшое объяснение, что в случае, если выражение не передается, результат будет одним и тем же.

@javascript-translate-bot javascript-translate-bot added changes requested Waiting for changes and /done from PR author and removed review needed Review needed, please approve or request changes labels Apr 14, 2023
@javascript-translate-bot
Copy link
Contributor

javascript-translate-bot commented Apr 14, 2023

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

sias32
sias32 commented Apr 15, 2023
View reviewed changes
Copy link
Contributor Author

@sias32 sias32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Внешние правки

sias32 and others added 5 commits April 15, 2023 10:30
@sias32 @Alexandre887
Update 1-js/02-first-steps/05-types/article.md
5b600a9 
Co-authored-by: Aleksandras <alex30955@aol.com>
@sias32 @Alexandre887
Update 1-js/02-first-steps/05-types/article.md
02c6640 
Co-authored-by: Aleksandras <alex30955@aol.com>
@sias32 @Alexandre887
Update 1-js/02-first-steps/05-types/article.md
6fc592e 
Co-authored-by: Aleksandras <alex30955@aol.com>
@sias32 @Alexandre887
Update 1-js/02-first-steps/05-types/article.md
59090d0 
Co-authored-by: Aleksandras <alex30955@aol.com>
@sias32 @Alexandre887
Update 1-js/02-first-steps/05-types/article.md
792bbba 
Co-authored-by: Aleksandras <alex30955@aol.com>
@sias32
Copy link
Contributor Author

sias32 commented Apr 15, 2023

Также в начале, где вы сравниваете typeof 5 и typeof(5), не помешало бы добавить небольшое объяснение, что в случае, если выражение не передается, результат будет одним и тем же.

Немного не понимаю, что вы имеете в виду

@sias32
Copy link
Contributor Author

sias32 commented Apr 15, 2023

/done

@javascript-translate-bot javascript-translate-bot added review needed Review needed, please approve or request changes and removed changes requested Waiting for changes and /done from PR author labels Apr 15, 2023
@javascript-translate-bot javascript-translate-bot requested a review from a team April 15, 2023 07:43
sias32
sias32 commented Apr 15, 2023
View reviewed changes
Copy link
Contributor Author

@sias32 sias32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Внешние правки

Alexandre887
Alexandre887 requested changes Apr 15, 2023
View reviewed changes
Copy link
Member

@Alexandre887 Alexandre887 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Этого будет достаточно.

@javascript-translate-bot javascript-translate-bot removed the review needed Review needed, please approve or request changes label Apr 15, 2023
@javascript-translate-bot
Copy link
Contributor

javascript-translate-bot commented Apr 15, 2023

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@javascript-translate-bot javascript-translate-bot added the changes requested Waiting for changes and /done from PR author label Apr 15, 2023
Alexandre887
Alexandre887 requested changes Apr 15, 2023
View reviewed changes
@javascript-translate-bot
Copy link
Contributor

javascript-translate-bot commented Apr 15, 2023

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Alexandre887
Alexandre887 approved these changes Apr 15, 2023
View reviewed changes
Copy link
Member

@Alexandre887 Alexandre887 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@javascript-translate-bot javascript-translate-bot added needs +1 One more review needed and removed changes requested Waiting for changes and /done from PR author labels Apr 15, 2023
@Alexandre887 Alexandre887 merged commit 7649089 into javascript-tutorial:master Apr 15, 2023
@sias32 sias32 deleted the patch-1 branch April 15, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Alexandre887 Alexandre887 Alexandre887 approved these changes

Assignees

No one assigned

Labels

needs +1 One more review needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sias32 @CLAassistant @javascript-translate-bot @Alexandre887