Skip to content

Update Config Value#189

Merged
risenW merged 2 commits intojavascriptdata:masterfrom
adithyaakrishna:bug/adithyaakrishna/issue#188
Apr 25, 2021
Merged

Update Config Value#189
risenW merged 2 commits intojavascriptdata:masterfrom
adithyaakrishna:bug/adithyaakrishna/issue#188

Conversation

@adithyaakrishna
Copy link
Copy Markdown
Contributor

Signed-off-by: Adithya Krishna aadithya794@gmail.com

This PR Fixes #188

Signed-off-by: Adithya Krishna <aadithya794@gmail.com>
@risenW risenW self-requested a review April 25, 2021 14:20
Comment thread danfojs-browser/src/plotting/plot.js Outdated
@adithyaakrishna
Copy link
Copy Markdown
Contributor Author

@risenW Is it possible if I can fix another issue in the same PR?
#77

As both of them are in the same files

Signed-off-by: Adithya Krishna <aadithya794@gmail.com>
@adithyaakrishna adithyaakrishna requested a review from risenW April 25, 2021 14:41
@risenW
Copy link
Copy Markdown
Member

risenW commented Apr 25, 2021

@risenW Is it possible if I can fix another issue in the same PR?
#77

As both of them are in the same files

Sure, you can do it. I see you did it already 👍

@risenW risenW merged commit dae90d8 into javascriptdata:master Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Read config value from x variable instead of y

2 participants