Generalize groupby to support more than two columns#196
Merged
steveoni merged 1 commit intojavascriptdata:masterfrom May 8, 2021
Merged
Generalize groupby to support more than two columns#196steveoni merged 1 commit intojavascriptdata:masterfrom
steveoni merged 1 commit intojavascriptdata:masterfrom
Conversation
Member
|
@sponsfreixes this looks awesome. I will clone this branch and test for more than two-columns. Thanks 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to provide better support for grouping by more than two columns.
The previous code explicitly checked if we were dealing with one or two columns, and ran different code branches depending on that. The proposed change treats both cases with the same code (no branching), and would do the same for any number of columns.
I do not consider the support for more than two columns finished with this PR because I didn't add any new tests for more than two columns. But I think that the PR is still a good contribution because it doesn't break the existing tests for one and two columns, and provides a better starting point for adding new tests for more columns and, in case of bugs, hopefully they should be localized fixes and not a major refactor.
Related issue: #162