fix(auth): add JWT cookie configuration options#117
Merged
javi11 merged 2 commits intojavi11:mainfrom Dec 11, 2025
MythodeaLoL:main-alt
Merged
fix(auth): add JWT cookie configuration options#117javi11 merged 2 commits intojavi11:mainfrom MythodeaLoL:main-alt
javi11 merged 2 commits intojavi11:mainfrom
MythodeaLoL:main-alt
Conversation
MythodeaLoL
commented
Dec 6, 2025
Contributor
Author
MythodeaLoL
left a comment
There was a problem hiding this comment.
Working on tests.
There was a problem hiding this comment.
Pull request overview
This PR fixes JWT cookie configuration by removing hardcoded values and using the service's loaded configuration instead of reloading on every cookie operation.
- Stores auth configuration in the Service struct and exposes it via
GetConfig() - Changes default
CookieDomainfrom"localhost"to""to allow browsers to use the current domain - Converts
http.SameSitevalues to Fiber cookie string format and applies configured SameSite values
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/auth/service.go | Stores config in Service struct, adds GetConfig() method, changes default CookieDomain to empty string, and passes JWTCookieDomain and SameSiteCookie to auth.Opts |
| internal/api/auth_handlers.go | Uses authService.GetConfig() instead of reloading config, adds sameSiteToString() helper function, and applies configured cookie settings |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
javi11
reviewed
Dec 8, 2025
javi11
approved these changes
Dec 11, 2025
drondeseries
referenced
this pull request
in drondeseries/altmount_old
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix JWT Cookie Domain Configuration
JWT cookies were hardcoded to
domain: "localhost"becausesetJWTCookie()andclearJWTCookie()reloaded configuration on every call instead of using the service's already-loaded config.Changes
internal/auth/service.goServicestruct, expose viaGetConfig()CookieDomainfrom"localhost"to""(browser uses current domain)JWTCookieDomainandSameSiteCookietoauth.Optsduring initialization"localhost"for URL construction when domain is emptyinternal/api/auth_handlers.gos.authService.GetConfig()instead ofauth.LoadConfigFromEnv()http.SameSiteto Fiber cookie string format ("Strict"/"Lax"/"None")SameSitevalue instead of hardcoded "Lax"http.SameSiteDefaultModeexplicitlyAddressed Review Comments
http.SameSiteDefaultModeinsameSiteToString()function to cover all http.SameSite valuesFix: #115