fix(windows): remove remaining SYMLINK guards missed by #607#608
Merged
Conversation
javi11#607 removed the guards in symlink_creator.go and health_handlers.go but two more remained: - internal/config/manager.go: validator rejecting SYMLINK on Windows at startup - internal/health/library_sync.go: guard blocking symlink updates in library sync Remove both blocks and their now-unused runtime imports. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#607 removed the Windows SYMLINK guards from
symlink_creator.goandhealth_handlers.gobut two more remained that prevent altmount from starting or functioning on Windows:internal/config/manager.go: startup config validator rejectsimport_strategy: SYMLINKon Windows with"SYMLINK is not supported on Windows; use STRM instead"— the binary exits immediately without servinginternal/health/library_sync.go: guard blocks symlink updates during library sync on WindowsBoth blocks follow the same
runtime.GOOS == "windows"pattern as the ones removed in #607. Also removed the now-unused"runtime"imports from both files.Test plan
go build ./...clean on Windowsimport_strategy: SYMLINKon Windows