[Mosaic GPU] Use explicit load/store methods instead of __getitem__/__setitem__ #28580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apaszke
added
the
CI Optional GPU Presubmit
copybara-service
bot
force-pushed
the
test_755845301
branch
from
d558dbb to
2b5a144
Compare
…_setitem__ We pretty never use slicing in those methods and I want to add the ability to load in other layouts than the default one (which means we will need extra non-index arguments). PiperOrigin-RevId: 756707034
copybara-service
bot
force-pushed
the
test_755845301
branch
from
2b5a144 to
244cb36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Mosaic GPU] Use explicit load/store methods instead of getitem/setitem
We pretty never use slicing in those methods and I want to add the ability to load
in other layouts than the default one (which means we will need extra non-index arguments).