Skip to content

[pull] main from openai:main #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 21, 2025
Merged

[pull] main from openai:main #73

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d1abf43
fix: Remove trailing commas causing tuple assignment in response canc…
gn00295120 Oct 21, 2025
e47a14f
fix: await cancelled websocket task to prevent resource leak (#1955)
gn00295120 Oct 21, 2025
9db9c01
fix: prevent race condition in listener iteration (#1956)
gn00295120 Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/agents/realtime/openai_realtime.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,8 @@ def remove_listener(self, listener: RealtimeModelListener) -> None:

async def _emit_event(self, event: RealtimeModelEvent) -> None:
"""Emit an event to the listeners."""
for listener in self._listeners:
# Copy list to avoid modification during iteration
for listener in list(self._listeners):
await listener.on_event(event)

async def _listen_for_messages(self):
Expand Down Expand Up @@ -431,7 +432,7 @@ async def _send_interrupt(self, event: RealtimeModelSendInterrupt) -> None:
and session.audio is not None
and session.audio.input is not None
and session.audio.input.turn_detection is not None
and session.audio.input.turn_detection.interrupt_response is True,
and session.audio.input.turn_detection.interrupt_response is True
)
if not automatic_response_cancellation_enabled:
await self._cancel_response()
Expand Down Expand Up @@ -516,6 +517,10 @@ async def close(self) -> None:
self._websocket = None
if self._websocket_task:
self._websocket_task.cancel()
try:
await self._websocket_task
except asyncio.CancelledError:
pass
self._websocket_task = None

async def _cancel_response(self) -> None:
Expand Down Expand Up @@ -616,7 +621,7 @@ async def _handle_ws_event(self, event: dict[str, Any]):
and session.audio is not None
and session.audio.input is not None
and session.audio.input.turn_detection is not None
and session.audio.input.turn_detection.interrupt_response is True,
and session.audio.input.turn_detection.interrupt_response is True
)
if not automatic_response_cancellation_enabled:
await self._cancel_response()
Expand Down
Loading