Support for punctuation in the :ignore option#10
Merged
jayjun merged 1 commit intojayjun:masterfrom Jun 19, 2020
Merged
Conversation
jayjun
requested changes
Jun 18, 2020
| replaced by hyphens. | ||
| """ | ||
|
|
||
| @punctuation ~c"!\"#$%&'()*+,-./:;<=>?@[\\]^_‘{|}~" |
Owner
There was a problem hiding this comment.
I believe :punct: includes ` (backtick) but not ‘ (left single quote).
Can you confirm?
Contributor
Author
There was a problem hiding this comment.
Good catch, you are correct. I also doubled checked the rest of characters, they seem to be correct.
simedw
changed the title
simedw
changed the title
Contributor
Author
|
Thanks for the feedback @jayjun , I have updated the PR. |
Owner
|
👍👌🤝👊🤘 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, thanks for a great library.
I have a use case in which I needed to ignore underscores, but since they are part of
[:punct:]usingignore: "_"didn't work.In this PR I extracted out the
:punct:to a list of characters and then filter out theignored_codepoints.