refactor(browser): split BrowserCookieStore into cookie_store.py (S6)#543
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR extracts ChangesCookie Store Module Extraction
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Modularity plan S6. Moves the self-contained
BrowserCookieStore(SQLCipher-encrypted cookie store, ~193 lines) out of the 1397-lineroutes/desktop_browser/store.pyinto its owncookie_store.py. The class shares no code withBrowserStore(it deliberately bypasses BaseStore to use the sync sqlcipher3 driver).To keep the many existing
from ...desktop_browser.store import BrowserCookieStoreimporters working unchanged, store.py re-exports the class. Verified the two import paths resolve to the same class object. No behavioral change.store.py 1397 → 1204 lines. +20 dedicated cookie tests pass; full desktop_browser suite (560 tests) passes. Preps the B4 store.py mixin split.
Summary by CodeRabbit
New Features