Skip to content

fix(agents): hide permitted-models section when its fetch fails (#583 follow-up)#586

Merged
jaylfc merged 1 commit into
devfrom
fix/framework-tab-permitted-loaded
Jun 4, 2026
Merged

fix(agents): hide permitted-models section when its fetch fails (#583 follow-up)#586
jaylfc merged 1 commit into
devfrom
fix/framework-tab-permitted-loaded

Conversation

@jaylfc
Copy link
Copy Markdown
Owner

@jaylfc jaylfc commented Jun 4, 2026

Fix-forward for the kilo review finding on #583.

loadPermitted's finally set permittedLoaded = true even when fetchPermittedModels threw, so the permitted-models section rendered (empty, "No models in the permitted set yet") on a failed load — contradicting the /* section stays hidden */ comment. Moved the flag into the success path; on error the section stays hidden as intended.

FrameworkTab vitest (4) pass; npm run build clean.

The finally block set permittedLoaded=true unconditionally, so the section
rendered (empty) even when fetchPermittedModels errored — contradicting the
comment that says it stays hidden. Move the flag into the success path so a
failed load leaves the section hidden as intended. Addresses the kilo review
finding on #583.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 4, 2026

Warning

Review limit reached

@jaylfc, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 19 minutes and 54 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: c32e2eba-701c-4994-870f-6216b5259e61

📥 Commits

Reviewing files that changed from the base of the PR and between 683b80a and 0bb161c.

📒 Files selected for processing (1)
  • desktop/src/components/agent-settings/FrameworkTab.tsx
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/framework-tab-permitted-loaded

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kilo-code-bot
Copy link
Copy Markdown

kilo-code-bot Bot commented Jun 4, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 files)
  • desktop/src/components/agent-settings/FrameworkTab.tsx - 0 issues

1 similar comment
@kilo-code-bot
Copy link
Copy Markdown

kilo-code-bot Bot commented Jun 4, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 files)
  • desktop/src/components/agent-settings/FrameworkTab.tsx - 0 issues

@kilo-code-bot
Copy link
Copy Markdown

kilo-code-bot Bot commented Jun 4, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 files)
  • desktop/src/components/agent-settings/FrameworkTab.tsx - 0 issues

Reviewed by nemotron-3-super-120b-a12b-20230311:free · 753,275 tokens

@jaylfc jaylfc merged commit 1ad97f1 into dev Jun 4, 2026
7 checks passed
@jaylfc jaylfc deleted the fix/framework-tab-permitted-loaded branch June 4, 2026 22:22
@github-project-automation github-project-automation Bot moved this from Todo to Done in TinyAgentOS Roadmap Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

1 participant