chore: add PR review guardrails#43
Closed
jayparikh wants to merge 1 commit into
Closed
Conversation
- add a lean pull request template with conditional UI checklist - add CODEOWNERS for UI, parser, docs, and workflow surfaces - tighten CI with typecheck and full screenshot verification - add pr:guard digest and policy checks for UI sync and hardcoded colors - document the review funnel in README Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
PR review digest
Policy signals
Changed files
|
paulyuk
added a commit
to paulyuk/agentviz
that referenced
this pull request
Apr 2, 2026
Addressed all PR review guardrails from jayparikh#43: ✅ Typecheck: clean (npx tsc --noEmit) ✅ Tests: 473/474 (1 pre-existing VS Code path test) ✅ Build: clean (npx vite build) ✅ Screenshots: all 8 originals present + journal-view.png added ✅ README: Steering view section added ✅ Style guide: Section 20 added for Steering view conventions ✅ Hardcoded colors: replaced all hex values with theme tokens (theme.accent.primary, theme.track.reasoning, theme.semantic.success) ✅ Test coverage: 3 test files for parser/server changes Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add lightweight repo guardrails so contributors get better review feedback before Jay has to do a deep manual pass.
Changes
npm run pr:guardplus a GitHub PR digest comment/job summaryWhy this helps
This creates a review funnel:
Validation
npm run pr:guard -- --base origin/main --head HEADnpm run typechecknpm testnpm run build