Fix environment configuration parsing and documentation issues#256
Merged
jaypatrick merged 2 commits intofeature/env-configurationfrom Feb 3, 2026
Merged
Fix environment configuration parsing and documentation issues#256jaypatrick merged 2 commits intofeature/env-configurationfrom
jaypatrick merged 2 commits intofeature/env-configurationfrom
Conversation
- Fix GitHub Actions setup-env to properly parse dotenv files (strip quotes, handle comments) - Update .envrc to use direnv's built-in dotenv loader instead of custom function - Update .env COMPILER_VERSION from 0.8.3 to 0.11.4 to match deno.json - Remove DENO_DIR from base .env (breaks GitHub Actions on /app/.deno path) - Fix .env.production to use empty placeholders for Turnstile keys - Update .env.production documentation to clarify wrangler secret usage - Fix wrangler.toml localConnectionString to use real connection string template - Update .github/ENV_SETUP.md branch mapping table to match actual behavior - Fix .env.README.md to clarify .envrc should be committed - Update deno.json dev task to remove --env=.envrc flag (now handled by direnv) Co-authored-by: jaypatrick <1800595+jaypatrick@users.noreply.github.com>
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
adblock-compiler | 78cadd7 | Feb 03 2026, 09:02 PM |
Copilot
AI
changed the title
[WIP] Implement layered environment configuration system
Fix environment configuration parsing and documentation issues
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses 11 issues from PR #254 review: broken dotenv parsing in GitHub Actions, quote handling in
.envrc, version mismatches, and misleading documentation.Dotenv Parsing
GitHub Actions - Replaced
grepwith proper parser that strips quotes and handles edge cases:.envrc- Use direnv's built-in loader instead of custom function:Configuration Fixes
0.8.3→0.11.4(sync withdeno.json).env(/app/.denobreaks GitHub Actions).env.production(prevent accidental verification)localConnectionStringto actual template vs env var name--env=.envrcflag (now direnv script, not dotenv file)Documentation
.env+.env.$ENVloaded, not just env-specific)wrangler secret put, not.env.local.envrcshould be committed, never contains secrets)💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.