feat: add artifacts directory for compiled binaries#274
Conversation
- Create artifacts/ directory for deno compile output - Update build task to output to artifacts/adblock-compiler - Add artifacts/ to .gitignore - Bump version to 0.11.7 Co-Authored-By: Warp <agent@warp.dev>
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
adblock-compiler | a1f6119 | Feb 09 2026, 02:21 AM |
There was a problem hiding this comment.
Pull request overview
This PR reorganizes local deno compile build output by moving the compiled CLI binary into a dedicated artifacts/ directory and bumps the project version.
Changes:
- Bump
deno.jsonversion to0.11.7. - Update
deno task buildto output the compiled binary toartifacts/adblock-compiler. - Ignore
artifacts/(and a couple of legacy binary names) in.gitignore.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| deno.json | Version bump and change build output path to artifacts/ |
| .gitignore | Ignore the new artifacts/ output directory (and additional binary names) |
| { | ||
| "name": "@jk-com/adblock-compiler", | ||
| "version": "0.11.6", | ||
| "version": "0.11.7", |
There was a problem hiding this comment.
The version bump here leaves the repo in an inconsistent state: package.json/package-lock.json are still at 0.11.6, and src/version.ts exports VERSION = 0.11.4 (used by PluginSystem as compilerVersion). Please update all version sources together (or adjust the versioning approach) so the reported library/compiler version is consistent across CLI, plugin API, and published metadata.
| "version": "0.11.7", | |
| "version": "0.11.4", |
| "dev": "deno run -A --watch --allow-read --allow-write --allow-net src/cli.ts", | ||
| "compile": "deno run --allow-read --allow-write --allow-net src/cli.ts", | ||
| "build": "deno compile --allow-read --allow-write --allow-net --output=adblock-compiler src/cli.ts", | ||
| "build": "deno compile --allow-read --allow-write --allow-net --output=artifacts/adblock-compiler src/cli.ts", |
There was a problem hiding this comment.
deno task build now outputs to artifacts/adblock-compiler, but the task doesn’t ensure the artifacts/ directory exists. On a clean checkout this can cause deno compile to fail when the parent directory is missing. Consider creating the directory as part of the task (in a cross-platform way) before invoking deno compile.
| "build": "deno compile --allow-read --allow-write --allow-net --output=artifacts/adblock-compiler src/cli.ts", | |
| "build": "deno run --allow-write -e \"await Deno.mkdir('artifacts', { recursive: true });\" && deno compile --allow-read --allow-write --allow-net --output=artifacts/adblock-compiler src/cli.ts", |
Changes
This improves the build process by organizing compiled binaries in a dedicated directory that is properly ignored by git.
Co-Authored-By: Warp agent@warp.dev