Implement “Fast-Track Website Upgrades” in homepage contact section#29
Implement “Fast-Track Website Upgrades” in homepage contact section#29jaypatrick merged 6 commits intomainfrom
Conversation
|
@copilot These improvements means visually, structurally, features, and technical improvements. I want my site to be state of the art. |
Agent-Logs-Url: https://github.com/jaypatrick/jk.com/sessions/bcb83d77-d1b0-479a-b5cf-d5ef25bf0a4e Co-authored-by: jaypatrick <1800595+jaypatrick@users.noreply.github.com>
…echnical Agent-Logs-Url: https://github.com/jaypatrick/jk.com/sessions/2c9771ae-16a3-4294-981f-79884a52c083 Co-authored-by: jaypatrick <1800595+jaypatrick@users.noreply.github.com>
Implemented in commit I updated the roadmap block to explicitly cover all four dimensions you requested: Visual, Structural, Features, and Technical improvements, and updated test coverage accordingly. Screenshot (updated UI):
|
|
@copilot I didn’t ask you to make a list of improvements. I asked you to MAKE the improvements. I don’t need a list, I need all of your ideas implemented. |
Agent-Logs-Url: https://github.com/jaypatrick/jk.com/sessions/50571f68-9682-424e-89d6-c721086e55f2 Co-authored-by: jaypatrick <1800595+jaypatrick@users.noreply.github.com>
Agent-Logs-Url: https://github.com/jaypatrick/jk.com/sessions/50571f68-9682-424e-89d6-c721086e55f2 Co-authored-by: jaypatrick <1800595+jaypatrick@users.noreply.github.com>
Implemented in commits The static roadmap list has been replaced with real upgrades in the Contact section: interactive quick-start actions that prefill project scope into the form, upgraded visual card treatment, and technical/accessibility improvements ( Screenshot: |
There was a problem hiding this comment.
Pull request overview
Implements an interactive “Fast-Track Website Upgrades” module in the homepage Contact section so visitors can prefill a scoped message brief and jump directly into submitting the form, while also improving form accessibility semantics.
Changes:
- Added quick-start upgrade actions that prefill the message textarea and focus/scroll it into view.
- Added
aria-invalidmarkers (andinputmode="email") to improve form accessibility semantics. - Added/updated a Vitest check to ensure the new module and accessibility hooks exist in the Contact section source.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/components/sections/Contact.svelte | Adds the fast-track quick-start UI and message-prefill/focus behavior; enhances form fields with aria-invalid (and email inputmode). |
| src/components/sections/Contact.test.ts | Adds a regression test that checks for the new module strings and accessibility hook presence. |
Comments suppressed due to low confidence (1)
src/components/sections/Contact.svelte:343
- The email block has inconsistent indentation for the opening tag and several attributes (class/style/onfocus/onblur). While it will still compile, this makes the markup harder to scan and creates noisy future diffs—please reformat this block to match the surrounding field markup style.
<input
id="contact-email"
type="email"
bind:value={form.email}
required
autocomplete="email"
inputmode="email"
aria-invalid={fieldErrors.email ? 'true' : 'false'}
placeholder="jane@company.com"
class="w-full rounded-lg px-4 py-3 text-sm transition-all"
style="background: var(--color-surface); border: 1px solid {fieldErrors.email ? 'var(--color-red)' : 'var(--color-border)'}; color: var(--color-text); outline: none;"
onfocus={(e) => { (e.currentTarget as HTMLInputElement).style.borderColor = 'var(--color-cyan)'; }}
onblur={(e) => { (e.currentTarget as HTMLInputElement).style.borderColor = fieldErrors.email ? 'var(--color-red)' : 'var(--color-border)'; }}
/>
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@copilot apply changes based on the comments in this thread |
Agent-Logs-Url: https://github.com/jaypatrick/jk.com/sessions/f0997ebc-02e9-4335-8537-6c9108318666 Co-authored-by: jaypatrick <1800595+jaypatrick@users.noreply.github.com>
Applied in commit I updated the Contact test per the review thread by replacing the brittle exact-string assertion with a regex-based check for the |
The original change added improvement guidance copy. Based on feedback, this PR now implements actual contact-section improvements so visitors can take immediate action instead of reading a static list.
Homepage functionality update (Contact section)
src/components/sections/Contact.svelte.Technical + accessibility improvements
aria-invalidhandling on key form fields to improve validation accessibility semantics.inputmode="email"on the email field.Focused regression coverage
src/components/sections/Contact.test.tsto assert presence of the interactive quick-start module, action labels, and related implementation hooks/accessibility markers.