Add independent security audit report for v1.0.0-rc1#5
Open
Akanimoh12 wants to merge 1 commit into
Open
Conversation
stream-manager.clar and stream-factory.clar.
|
@Akanimoh12 is attempting to deploy a commit to the dev_jaytee's projects Team on Vercel. A member of the Team first needs to authorize it. |
jayteemoney
added a commit
that referenced
this pull request
May 19, 2026
H-1 (Akanimoh, PR #5): stream-factory had no reactivate-dao - deactivated DAOs were permanently locked out of the registry and their name burned in dao-names forever. Added reactivate-dao public function with ERR-DAO-ALREADY-ACTIVE (err u508). F-1 (Majormaxx, PR #7): top-up-stream on a paused stream allowed sender to extend end-block indefinitely with minimum-valid top-ups, permanently griefing expire-stream. Added paused-state guard before the end-block check. F-2 (Majormaxx, PR #7): update-dao-name had no is-active check, letting a deactivated DAO release its locked name via map-delete and enabling name squatting. Added ERR-DAO-INACTIVE (err u507) and is-active guard. F-3 (Majormaxx, PR #7): track-stream had no is-active check, letting a deactivated DAO inflate its own analytics post-deactivation. Same ERR-DAO-INACTIVE guard. Error-code numbering: ERR-DAO-INACTIVE=u507 (Majormaxx, 2 call sites), ERR-DAO-ALREADY-ACTIVE=u508 (renumbered from u507 to avoid collision). Test suite: 113 -> 125 passing tests (+12 covering all four fixes plus updated L-10 test for new error ordering).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds auditors-report/security-audit-report-by-akanimoh.md covering stream-manager.clar and stream-factory.clar. No critical/fund-loss bugs found. Key items: H-1 (deactivated DAOs locked out of factory — launch blocker, needs reactivate-dao), plus 2 medium and 6 low/info findings.