Use a claude and gemini compatible agentic sandbox by jbcoe · Pull Request #70 · jbcoe/cc-protocol

jbcoe · 2026-04-16T23:19:03Z

Support OAuth authentication rather than an API key to reduce costs.

Use OAuth authentication rather than an API key to reduce costs.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-16T23:51:09Z

+            [
+                "docker",
+                "build",
+                "--build-arg",
+                f"AGENT={args.agent}",
+                "-t",
+                image_name,
+                "-f",
+                os.path.join(project_root, "docker/Dockerfile"),
+                project_root,
+            ]


docker build is passing --build-arg AGENT=..., but the Dockerfile doesn't use AGENT anywhere, so the build arg (and ARG AGENT=gemini) are currently redundant and can confuse readers about what varies between the ...-gemini-sandbox and ...-claude-sandbox images. Either remove the build arg/ARG entirely, or actually use it (e.g., to conditionally install only the selected CLI) so the tag difference reflects a real image difference.

Copilot · 2026-04-16T23:51:09Z

-Use `--rebuild-docker` to rebuild the container image and `--update-claude` to
-update the Claude Code CLI inside the container.
+where `<agent>` is either `claude` or `gemini`.



The sandbox docs no longer mention API keys (good), but they also don't explain the new OAuth-based auth flow (e.g., that the script mounts ~/.gemini / ~/.claude{,.json} from the host and that first-run will prompt a login). Adding a brief note here would prevent users from thinking the sandbox is broken when the agent asks for auth.

Suggested change

Authentication uses the agent CLI's OAuth-based login flow rather than API

keys. The sandbox mounts your existing host authentication state (for example,

`~/.gemini` and `~/.claude` / `~/.claude.json`) into the container. On first

run, if you have not already authenticated locally, the agent may prompt you

to sign in; this is expected and does not indicate that the sandbox is broken.

Copilot · 2026-04-16T23:51:10Z

+            fd = os.open(
+                trusted_folders_path, os.O_CREAT | os.O_EXCL | os.O_WRONLY, 0o600
+            )
+            os.write(fd, b'{"/workspace": "TRUST_FOLDER"}')
+            os.close(fd)
+        except FileExistsError:
+            pass
+        settings_path = os.path.join(gemini_config_dir, "settings.json")
+        try:
+            fd = os.open(settings_path, os.O_CREAT | os.O_EXCL | os.O_WRONLY, 0o600)
+            os.write(fd, b'{"selectedAuthType": "oauth-personal"}')
+            os.close(fd)
+        except FileExistsError:


The config seeding uses os.open/os.write/os.close in-line; if os.write raises, the fd won't be closed. Consider wrapping the fd in a context manager (or using try/finally) and extracting a small helper to reduce duplication between the two file-creation blocks.

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-16T23:56:25Z

+
+    args = parser.parse_args()
+
+    def log(msg: str) -> None:
+        """Log a message if verbose mode is enabled."""


The Docker image name is agent-specific (cc-protocol-{agent}-sandbox), but the Dockerfile installs both CLIs unconditionally. After building one image, running the other agent will fail unless its separate image is also built, and you end up with duplicated identical images. Consider either using a single shared image name (since both CLIs are present) or making the Dockerfile conditional on AGENT so per-agent images are meaningful.

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-17T00:07:10Z

+    try:
+        os.write(fd, content)
+    finally:
+        os.close(fd)


os.write() is not guaranteed to write the full buffer; this can result in truncated JSON in the seeded config files. Consider writing via os.fdopen(fd, 'wb') / .write() (or loop until all bytes are written) so the file contents are reliably complete.

Suggested change

try:

os.write(fd, content)

finally:

os.close(fd)

with os.fdopen(fd, "wb") as file_obj:

file_obj.write(content)

Copilot · 2026-04-17T00:07:11Z

+        os.makedirs(host_claude_dir, mode=0o700, exist_ok=True)
+        # Ensure the file exists on the host so Docker doesn't create it as a directory.
+        # Use os.open with restrictive permissions to avoid exposing credentials to
+        # other local users on multi-user systems.


If ~/.claude.json already exists but is a directory (e.g., from a previous Docker run where the file path was mounted before being created), this will attempt to create/open it as a file and raise IsADirectoryError. Add an explicit os.path.isdir(host_claude_json) check and fail with a clear remediation message (or replace it) before proceeding.

Suggested change

# other local users on multi-user systems.

# other local users on multi-user systems.

if os.path.isdir(host_claude_json):

sys.exit(

f"{host_claude_json} exists as a directory, but Claude expects this path "

"to be a file. Remove or rename that directory and rerun this script so "

"it can create an empty ~/.claude.json file."

)

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

philipcraig

Looks good

jbcoe · 2026-04-17T07:46:05Z

@philipcraig have you tried it?

philipcraig · 2026-04-17T07:47:38Z

I can't from here. The work laptop is locked down against non work LLM use. I'll be back in Monday

jbcoe · 2026-04-17T07:53:01Z

@nbx8 @Twon looking for approval from someone who can check this locally.

Twon · 2026-04-17T10:39:06Z

Works on Windows

Use a claude and gemini compatible agentic sandbox

740efbe

Use OAuth authentication rather than an API key to reduce costs.

jbcoe requested a review from Copilot April 16, 2026 23:19

Copilot started reviewing on behalf of jbcoe April 16, 2026 23:19 View session

Remove legacy claude sandbox scripts

2d618e8

This comment was marked as outdated.

Sign in to view

jbcoe and others added 2 commits April 17, 2026 00:28

Update contributing guide

ebdc24c

Update docker/Dockerfile

f7bf680

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

jbcoe requested a review from Copilot April 16, 2026 23:30

Copilot started reviewing on behalf of jbcoe April 16, 2026 23:31 View session

This comment was marked as outdated.

Sign in to view

Address review comments

3fe781c

jbcoe requested a review from Copilot April 16, 2026 23:48

Copilot started reviewing on behalf of jbcoe April 16, 2026 23:48 View session

Copilot AI reviewed Apr 16, 2026

View reviewed changes

jbcoe requested a review from Copilot April 16, 2026 23:53

Copilot started reviewing on behalf of jbcoe April 16, 2026 23:53 View session

Address review comments

ecb07a6

Copilot AI reviewed Apr 16, 2026

View reviewed changes

jbcoe added 2 commits April 17, 2026 01:00

Address review comments

0e3b159

Address review comments

50710ad

jbcoe requested review from Copilot and nbx8 April 17, 2026 00:03

Copilot started reviewing on behalf of jbcoe April 17, 2026 00:04 View session

Copilot AI reviewed Apr 17, 2026

View reviewed changes

jbcoe requested review from Copilot and removed request for nbx8 April 17, 2026 00:10

Copilot started reviewing on behalf of jbcoe April 17, 2026 00:11 View session

Copilot AI reviewed Apr 17, 2026

View reviewed changes

Comment thread scripts/agentic-sandbox.py Outdated

Comment thread docker/Dockerfile Outdated

jbcoe and others added 2 commits April 17, 2026 08:02

Update scripts/agentic-sandbox.py

9a16a9d

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update docker/Dockerfile

672bf89

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

jbcoe requested review from Twon, nbx8 and philipcraig April 17, 2026 07:02

philipcraig approved these changes Apr 17, 2026

View reviewed changes

Twon approved these changes Apr 17, 2026

View reviewed changes

jbcoe merged commit 5986d05 into main Apr 17, 2026
1 check passed

jbcoe deleted the agentic-dev branch April 17, 2026 10:42

+Authentication uses the agent CLI's OAuth-based login flow rather than API
+keys. The sandbox mounts your existing host authentication state (for example,
+`~/.gemini` and `~/.claude` / `~/.claude.json`) into the container. On first
+run, if you have not already authenticated locally, the agent may prompt you
+to sign in; this is expected and does not indicate that the sandbox is broken.

-        # other local users on multi-user systems.
+        # other local users on multi-user systems.
+        if os.path.isdir(host_claude_json):
+            sys.exit(
+                f"{host_claude_json} exists as a directory, but Claude expects this path "
+                "to be a file. Remove or rename that directory and rerun this script so "
+                "it can create an empty ~/.claude.json file."
+            )

Conversation

jbcoe commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

philipcraig left a comment

Choose a reason for hiding this comment

Uh oh!

jbcoe commented Apr 17, 2026

Uh oh!

philipcraig commented Apr 17, 2026

Uh oh!

jbcoe commented Apr 17, 2026

Uh oh!

Twon commented Apr 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jbcoe commented Apr 16, 2026 •

edited

Loading