Brew formula update for radioactive_ralph version v0.8.1#10
Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 46 minutes and 8 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The validator required top-level `url` + `hash` keys, which is the
single-arch/legacy shape. GoReleaser v2 (and modern Scoop itself)
emit the multi-arch shape with `url` and `hash` nested under
`architecture.{64bit,32bit,arm64}`.
This blocked PR #10 (radioactive-ralph v0.8.1) — the manifest was
valid Scoop but the validator rejected it.
New logic: top-level url+hash pass, OR an `architecture` block with
at least one known arch sub-block containing both url and hash.
Flat-shape manifests still pass unchanged. Includes coverage for
obviously-broken manifests (no top-level, no architecture block;
architecture block present but missing url/hash).
There was a problem hiding this comment.
Pull request overview
Updates the Homebrew formula and Scoop manifest for radioactive-ralph to release v0.8.1 (automated via GoReleaser).
Changes:
- Bumped
radioactive-ralphto v0.8.1 with updated release URLs and SHA256 hashes. - Updated package descriptions and added user-facing setup guidance (Homebrew
caveats, Scooppost_install).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
bucket/radioactive-ralph.json |
Updates Scoop manifest to v0.8.1, adds post_install guidance, and restructures manifest fields. |
Formula/radioactive-ralph.rb |
Updates Homebrew formula to v0.8.1 with new tarball URLs/hashes and adds a caveats message. |
| "version": "0.8.1", | ||
| "architecture": { | ||
| "64bit": { | ||
| "url": "https://github.com/jbcom/radioactive-ralph/releases/download/v$version/radioactive_ralph_$version_windows_amd64.zip" | ||
| } | ||
| } | ||
| } | ||
| "64bit": { | ||
| "url": "https://github.com/jbcom/radioactive-ralph/releases/download/v0.8.1/radioactive_ralph_0.8.1_windows_amd64.zip", |
There was a problem hiding this comment.
The Scoop manifest dropped checkver/autoupdate. In this repo, manifests keep these blocks (e.g., bucket/paranoid-passwd.json:15-24) so scoop update can discover new releases automatically. Please restore checkver.github and an autoupdate.architecture.64bit.url template (using $version).
| "architecture": { | ||
| "64bit": { | ||
| "url": "https://github.com/jbcom/radioactive-ralph/releases/download/v$version/radioactive_ralph_$version_windows_amd64.zip" | ||
| } | ||
| } | ||
| } | ||
| "64bit": { | ||
| "url": "https://github.com/jbcom/radioactive-ralph/releases/download/v0.8.1/radioactive_ralph_0.8.1_windows_amd64.zip", | ||
| "bin": [ | ||
| "radioactive_ralph.exe" | ||
| ], | ||
| "hash": "5f71a72ce9fe913f163eb8f0f8970f7a70b41fbb8eed4a9c80e7bcc71d90f9c2" | ||
| } |
There was a problem hiding this comment.
This manifest now only defines url/hash/bin under architecture.64bit, and also switches to 4-space indentation. Other bucket entries keep url, hash, and bin at the top level (and optionally duplicate under architecture) with 2-space indentation for consistency (see bucket/paranoid-passwd.json:1-14). Consider restoring the top-level fields and formatting to match the bucket conventions.
| define_method(:install) do | ||
| bin.install "radioactive_ralph" | ||
| end | ||
| end | ||
| if Hardware::CPU.arm? | ||
| url "https://github.com/jbcom/radioactive-ralph/releases/download/v0.8.1/radioactive_ralph_0.8.1_darwin_arm64.tar.gz" | ||
| sha256 "a61bc1d7d7f58d7d8f2e5bc7c26b367d9352527b07b6bdd1724ab823904d09f2" | ||
|
|
||
| define_method(:install) do | ||
| bin.install "radioactive_ralph" | ||
| end |
There was a problem hiding this comment.
install is being defined via define_method(:install) inside each CPU conditional, duplicating the same body multiple times. In this repo’s other formula (Formula/paranoid-passwd.rb:34-36), def install is defined once outside the platform/arch conditionals. Defining install once reduces duplication and avoids cases where none of the conditionals match (leaving install undefined).
* docs: canonical URL is https://jonbogaty.com/pkgs/ The operator's apex jonbogaty.com already CNAMEs to jbcom.github.io repo-wide, so GitHub Pages transparently serves /pkgs/ on the apex with no reverse proxy needed. Updates astro.config.mjs `site` field to feed correct absolute URLs into sitemap + OG tags, and aligns README / CLAUDE.md / AGENTS.md / docs/ to the real canonical URL. jbcom.github.io/pkgs/ 301-redirects to the canonical URL. * fix(ci): accept multi-arch Scoop manifests in validator The validator required top-level `url` + `hash` keys, which is the single-arch/legacy shape. GoReleaser v2 (and modern Scoop itself) emit the multi-arch shape with `url` and `hash` nested under `architecture.{64bit,32bit,arm64}`. This blocked PR #10 (radioactive-ralph v0.8.1) — the manifest was valid Scoop but the validator rejected it. New logic: top-level url+hash pass, OR an `architecture` block with at least one known arch sub-block containing both url and hash. Flat-shape manifests still pass unchanged. Includes coverage for obviously-broken manifests (no top-level, no architecture block; architecture block present but missing url/hash). --------- Co-authored-by: Your Name <you@example.com>
There was a problem hiding this comment.
Code Review
This pull request updates the radioactive-ralph Homebrew formula to version 0.8.1, which includes updated binary URLs, SHA256 hashes, and a new caveats section. The review feedback points out that the use of define_method(:install) within architecture-specific blocks is redundant and non-idiomatic for Homebrew formulae. It is recommended to use a single, class-level install method since the installation logic is identical across all platforms.
| on_macos do | ||
| if Hardware::CPU.arm? | ||
| url "https://github.com/jbcom/radioactive-ralph/releases/download/v0.6.0/radioactive_ralph_0.6.0_darwin_arm64.tar.gz" | ||
| sha256 "0000000000000000000000000000000000000000000000000000000000000000" | ||
| end | ||
| if Hardware::CPU.intel? | ||
| url "https://github.com/jbcom/radioactive-ralph/releases/download/v0.6.0/radioactive_ralph_0.6.0_darwin_amd64.tar.gz" | ||
| sha256 "0000000000000000000000000000000000000000000000000000000000000000" | ||
| url "https://github.com/jbcom/radioactive-ralph/releases/download/v0.8.1/radioactive_ralph_0.8.1_darwin_amd64.tar.gz" | ||
| sha256 "ba400436d17777c3a69103f04f47f81f0b96b23eec5210354ae94dad041e2624" | ||
|
|
||
| define_method(:install) do | ||
| bin.install "radioactive_ralph" | ||
| end | ||
| end | ||
| if Hardware::CPU.arm? | ||
| url "https://github.com/jbcom/radioactive-ralph/releases/download/v0.8.1/radioactive_ralph_0.8.1_darwin_arm64.tar.gz" | ||
| sha256 "a61bc1d7d7f58d7d8f2e5bc7c26b367d9352527b07b6bdd1724ab823904d09f2" | ||
|
|
||
| define_method(:install) do | ||
| bin.install "radioactive_ralph" | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
The use of define_method(:install) inside architecture-specific blocks is redundant and non-idiomatic for Homebrew formulae. Since the installation logic (bin.install "radioactive_ralph") is identical across all platforms and architectures, it should be defined once at the class level using a standard def install method. This improves readability and maintainability.
on_macos do
if Hardware::CPU.intel?
url "https://github.com/jbcom/radioactive-ralph/releases/download/v0.8.1/radioactive_ralph_0.8.1_darwin_amd64.tar.gz"
sha256 "ba400436d17777c3a69103f04f47f81f0b96b23eec5210354ae94dad041e2624"
end
if Hardware::CPU.arm?
url "https://github.com/jbcom/radioactive-ralph/releases/download/v0.8.1/radioactive_ralph_0.8.1_darwin_arm64.tar.gz"
sha256 "a61bc1d7d7f58d7d8f2e5bc7c26b367d9352527b07b6bdd1724ab823904d09f2"
end
end| on_linux do | ||
| if Hardware::CPU.arm? && Hardware::CPU.is_64_bit? | ||
| url "https://github.com/jbcom/radioactive-ralph/releases/download/v0.6.0/radioactive_ralph_0.6.0_linux_arm64.tar.gz" | ||
| sha256 "0000000000000000000000000000000000000000000000000000000000000000" | ||
| if Hardware::CPU.intel? && Hardware::CPU.is_64_bit? | ||
| url "https://github.com/jbcom/radioactive-ralph/releases/download/v0.8.1/radioactive_ralph_0.8.1_linux_amd64.tar.gz" | ||
| sha256 "c6410ccdf5c445ed4eb6edd3985ca35a7c5256e40f5e2f32124efbad6ad41c42" | ||
| define_method(:install) do | ||
| bin.install "radioactive_ralph" | ||
| end | ||
| end | ||
| if Hardware::CPU.intel? | ||
| url "https://github.com/jbcom/radioactive-ralph/releases/download/v0.6.0/radioactive_ralph_0.6.0_linux_amd64.tar.gz" | ||
| sha256 "0000000000000000000000000000000000000000000000000000000000000000" | ||
| if Hardware::CPU.arm? && Hardware::CPU.is_64_bit? | ||
| url "https://github.com/jbcom/radioactive-ralph/releases/download/v0.8.1/radioactive_ralph_0.8.1_linux_arm64.tar.gz" | ||
| sha256 "5e293196eb6291cf5a06f7bca49a2e9a91fb63059fde434b263b5e71e0d47686" | ||
| define_method(:install) do | ||
| bin.install "radioactive_ralph" | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
Similar to the macOS block, the redundant define_method(:install) calls should be removed in favor of a single class-level install method.
on_linux do
if Hardware::CPU.intel? && Hardware::CPU.is_64_bit?
url "https://github.com/jbcom/radioactive-ralph/releases/download/v0.8.1/radioactive_ralph_0.8.1_linux_amd64.tar.gz"
sha256 "c6410ccdf5c445ed4eb6edd3985ca35a7c5256e40f5e2f32124efbad6ad41c42"
end
if Hardware::CPU.arm? && Hardware::CPU.is_64_bit?
url "https://github.com/jbcom/radioactive-ralph/releases/download/v0.8.1/radioactive_ralph_0.8.1_linux_arm64.tar.gz"
sha256 "5e293196eb6291cf5a06f7bca49a2e9a91fb63059fde434b263b5e71e0d47686"
end
end|
|
||
| def install | ||
| bin.install "radioactive_ralph" | ||
| def caveats |
Automated with GoReleaser