fix(ci): add workflow_dispatch trigger to release.yml#161
Conversation
The pr output is a JSON PullRequest object, not a PR number. Extract the number with jq. Split approve and merge into separate steps with continue-on-error on approve (GITHUB_TOKEN can't self-approve PRs it created). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When release-please auto-merges its own PR via GITHUB_TOKEN, the push event doesn't trigger a new workflow run (GitHub's cascading prevention). Adding workflow_dispatch allows manual triggering to complete the release flow. Long-term fix: use a PAT for release-please so merged PR pushes trigger workflows normally. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
Note 🎁 Summarized by CodeRabbit FreeThe PR author is not assigned a seat. To perform a comprehensive line-by-line review, please assign a seat to the pull request author through the subscription management page by visiting https://app.coderabbit.ai/login. Comment |
There was a problem hiding this comment.
Review Summary
🛑 Critical Logic Error - Workflow Won't Function as Intended
The workflow_dispatch trigger has been added correctly, but the workflow will not function when manually triggered. The release-please job has a condition on line 18:
if: github.event_name == 'push'When the workflow is manually triggered, github.event_name will be workflow_dispatch, not push, causing the job to be skipped. This defeats the purpose stated in the PR description.
Required Fix:
Change line 18 to:
if: github.event_name == 'push' || github.event_name == 'workflow_dispatch'This will allow the release-please job to run both on push events and when manually triggered, achieving the intended workaround for the GITHUB_TOKEN limitation.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
Coverage Report
File CoverageNo changed files found. |
Summary
workflow_dispatchtrigger so the Release workflow can be manually runContext
When release-please auto-merges its PR via GITHUB_TOKEN, the push to main doesn't create a new workflow run. This means release-please never gets a chance to detect the merged PR and create the GitHub Release + tag.
Workaround: After a release-please PR auto-merges, manually trigger the Release workflow.
Long-term fix: Use a PAT (Personal Access Token) as the
tokeninput for release-please-action. This allows the merged PR push to trigger workflows normally.Test plan
🤖 Generated with Claude Code