Skip to content

fix(ci): add workflow_dispatch trigger to release.yml#161

Merged
jbdevprimary merged 4 commits into
mainfrom
fix/release-workflow-dispatch
Feb 25, 2026
Merged

fix(ci): add workflow_dispatch trigger to release.yml#161
jbdevprimary merged 4 commits into
mainfrom
fix/release-workflow-dispatch

Conversation

@jbdevprimary
Copy link
Copy Markdown
Contributor

Summary

  • Add workflow_dispatch trigger so the Release workflow can be manually run
  • Needed because auto-merged release-please PRs don't trigger new workflow runs (GITHUB_TOKEN limitation)

Context

When release-please auto-merges its PR via GITHUB_TOKEN, the push to main doesn't create a new workflow run. This means release-please never gets a chance to detect the merged PR and create the GitHub Release + tag.

Workaround: After a release-please PR auto-merges, manually trigger the Release workflow.

Long-term fix: Use a PAT (Personal Access Token) as the token input for release-please-action. This allows the merged PR push to trigger workflows normally.

Test plan

  • After merge, manually trigger Release workflow to create v1.0.0 release

🤖 Generated with Claude Code

jbdevprimary and others added 4 commits February 24, 2026 18:05
The pr output is a JSON PullRequest object, not a PR number.
Extract the number with jq. Split approve and merge into separate
steps with continue-on-error on approve (GITHUB_TOKEN can't
self-approve PRs it created).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When release-please auto-merges its own PR via GITHUB_TOKEN, the
push event doesn't trigger a new workflow run (GitHub's cascading
prevention). Adding workflow_dispatch allows manual triggering to
complete the release flow.

Long-term fix: use a PAT for release-please so merged PR pushes
trigger workflows normally.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@gemini-code-assist
Copy link
Copy Markdown

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 25, 2026

Warning

Rate limit exceeded

@jbdevprimary has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 11 minutes and 25 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 00b4b0f and 0f0a97b.

📒 Files selected for processing (1)
  • .github/workflows/release.yml

Note

🎁 Summarized by CodeRabbit Free

The PR author is not assigned a seat. To perform a comprehensive line-by-line review, please assign a seat to the pull request author through the subscription management page by visiting https://app.coderabbit.ai/login.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@amazon-q-developer amazon-q-developer Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

🛑 Critical Logic Error - Workflow Won't Function as Intended

The workflow_dispatch trigger has been added correctly, but the workflow will not function when manually triggered. The release-please job has a condition on line 18:

if: github.event_name == 'push'

When the workflow is manually triggered, github.event_name will be workflow_dispatch, not push, causing the job to be skipped. This defeats the purpose stated in the PR description.

Required Fix:

Change line 18 to:

if: github.event_name == 'push' || github.event_name == 'workflow_dispatch'

This will allow the release-please job to run both on push events and when manually triggered, achieving the intended workaround for the GITHUB_TOKEN limitation.


You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.

@github-actions
Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 85.36% (🎯 80%) 4595 / 5383
🔵 Statements 84.51% (🎯 80%) 4966 / 5876
🔵 Functions 82.88% (🎯 80%) 1492 / 1800
🔵 Branches 74.77% (🎯 73%) 2825 / 3778
File CoverageNo changed files found.
Generated in workflow #570 for commit 0f0a97b by the Vitest Coverage Report Action

@jbdevprimary jbdevprimary merged commit 7018be5 into main Feb 25, 2026
12 checks passed
@jbdevprimary jbdevprimary deleted the fix/release-workflow-dispatch branch February 25, 2026 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant