JBDS-3361 fetch target platform zip, unpack it, and use it within JBDS update site >> master

[nickboldt]

No description provided.

[dgolovin]

There is no target platform folder in PR or current repository. Am I missing something or some resources are missing in PR?

[dgolovin]

I got

The build could not read 1 project -> [Help 1]
[ERROR]   
[ERROR]   The project com.jboss.devstudio:product:9.0.0-SNAPSHOT (/home/eskimo/Projects/jbdevstudio/4.3.x/fork/jbds-releng/jbdevstudio-product/pom.xml) has 1 error
[ERROR]     Child module /home/eskimo/Projects/jbdevstudio/4.3.x/fork/jbds-releng/jbdevstudio-product/targetplatform of /home/eskimo/Projects/jbdevstudio/4.3.x/fork/jbds-releng/jbdevstudio-product/pom.xml does not exist
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.

[nickboldt]

Sorry about that; missed that in the commit. Added here:

https://github.com/nickboldt/jbdevstudio-product/blob/JBDS-3361_getzip_master/targetplatform/pom.xml

[dgolovin]

IMO to many changes for small fix.
It should be all done in results module:

1. get two dependencies teargetplatform and jbdsupdatesite (result of site/pom.xml build which is available from the same reactor and installed into local maven repo)
2. combine it together (maven assembly looks good here) with target name the same as current jbds update site zip

It is going to be change only in results/pom.xml and all done on maven side.

[nickboldt]

Why in results? Results is really just for renaming & moving stuff around.

My way is what you asked for in the previous PR: instead of mirroring the TP, fetch the zip. Then use that in update site build and installer.

If we did the work in the results phase, we'd still be fetching TP for the installer, then doing it AGAIN in results.

This is more efficient.

[dgolovin]

You right about target platform. It is good to have it downloaded as a zip, but in current PR it still going to be downloaded twice:

1. during tycho tp resolution process
2. during targetplatform/pom.xml build

[dgolovin]

devstudio-earlyaccess.properties download during build is killing me ;(

[dgolovin]

Still cannot build product with this PR

[ERROR] Failed to execute goal org.eclipse.tycho.extras:tycho-p2-extras-plugin:0.22.0:mirror (default) on project installer: Error during mirroring: Could not find IU [com.jboss.devstudio.core.package, 0.0.0] in any of the source repositories [file:///home/eskimo/data/Projects/jbdevstudio/4.3.x/fork/jbds-releng/jbdevstudio-product/installer/target/jbds-repo-with-sources/, file:///home/eskimo/data/Projects/jbdevstudio/4.3.x/fork/jbds-releng/jbdevstudio-product/targetplatform/target/]

[dgolovin]

Where is latest aggregated JBT Core 4.3.0.Alpha2 published ?

[nickboldt]

You can get latest from here:

http://download.jboss.org/jbosstools/mars/snapshots/builds/jbosstools-build-sites.aggregate.site_master/latest/all/repo/
or
http://download.jboss.org/jbosstools/mars/snapshots/updates/core/master/

[nickboldt]

replaced by #284