add_library & and_executable omitted sources added back#760
Closed
fyazici wants to merge 1 commit intojbeder:masterfrom
fyazici:master
Closed
add_library & and_executable omitted sources added back#760fyazici wants to merge 1 commit intojbeder:masterfrom fyazici:master
fyazici wants to merge 1 commit intojbeder:masterfrom
fyazici:master
Conversation
…0.x and below compatibility
Contributor
|
Hi apologies about this. I forgot to add a space between the target name and the closing parentheses. This is technically how its supposed to be done. In other words: add_library(yaml-cpp ${yaml-cpp-type} "")would also work. That said, before this gets merged @jbeder, either the put an empty string approach should be taken, or the |
Contributor
Author
|
@slurps-mad-rips no worries. I will try your suggestion on my 16.04 machine just in case. I am closing this PR for now. If that works as expected I will open a new PR with your solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for cmake 3.10.x and below compatibility. related to issue #757 (by me) and #759 (by another user)