Skip to content

Fix tree coloring#5

Merged
jbloom merged 4 commits intomainfrom
fix-tree-coloring
May 9, 2026
Merged

Fix tree coloring#5
jbloom merged 4 commits intomainfrom
fix-tree-coloring

Conversation

@jbloom
Copy link
Copy Markdown
Member

@jbloom jbloom commented May 9, 2026

No description provided.

jbloom and others added 4 commits May 6, 2026 16:38
…oring

When color_tree_by was set alongside a user chart that had its own color
encoding (e.g. a titer plot colored by cell_line), Vega-Lite's default
of sharing color scales across concat views merged the tree's
color_value:N scale into the user chart's color scale. The user-chart
domain was lost and its marks rendered without color. _concat_for_location
now passes color="independent" to resolve_scale alongside the existing
strain-axis resolution, so the tree's invented color_value:N scale stays
isolated from whatever the user has on their chart.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
`mark_line`, `mark_trail`, and `mark_area` now connect points in tree
tip order regardless of other encodings on the chart. Previously, a
ser chart with an explicit categorical color-scale `domain` rendered
with crisscrossing line segments because Vega-Lite's default
connection-order heuristic ignored the strain-axis sort. The package
now attaches a `calculate` transform that derives a per-row tip rank
and points the `order` channel at that field on these marks. Any
user-supplied `order` is left in place.
@jbloom jbloom merged commit 5dd598d into main May 9, 2026
3 checks passed
@jbloom jbloom deleted the fix-tree-coloring branch May 9, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant