JBTIS-1078 - updates for Oxygen compatibility

[bfitzpat]

DO NOT MERGE THIS YET

@pleacu I need some help figuring out why the TP is not picking up the right Graphiti version for the BPMN2 modeler - is it possible you haven't updated it to the 0.14 version of graphiti?

I'm seeing this:

[ERROR] Cannot resolve project dependencies:
[ERROR] Software being installed: org.switchyard.tools.ui.bpmn2 2.4.0.qualifier
[ERROR] Missing requirement: org.eclipse.bpmn2.modeler.core 1.3.1.Final-v20160831-1132-B55 requires 'bundle org.eclipse.graphiti [0.12.0,0.14.0)' but it could not be found
[ERROR] Cannot satisfy dependency: org.switchyard.tools.ui.bpmn2 2.4.0.qualifier depends on: bundle org.eclipse.bpmn2.modeler.core [1.1.0,1.5.0)

[pleacu]

@bfitzpat - add this to your eclipse/pom.xml

bpmn2-editor-update-site - http://download.jboss.org/jbosstools/updates/requirements/bpmn2-modeler/1.3.1.Final_1.3.0.Final_neon/ + http://download.jboss.org/jbosstools/updates/requirements/bpmn2-modeler/oxygen/1.4.0.Final_1.3.1.Final_oxygen/ p2 true

[bfitzpat]

@pleacu I don't understand what you're asking me to add here. Do you have an example?

[bfitzpat]

Thanks for the assistance @pleacu . I missed one reference to the Neon update site for BPMN2 that needed to be updated. Builds locally, now we see if it builds upstream.

[pleacu]

Looks good!

[apupier]

any specific reason to put an upperbound for the dependency?

[bfitzpat]

Yes. We hit some issues using the 1.4.0) version we had set before. Apparently "1.4.0.Final-v20170331-1748-B11" exceeds the 1.4.0 version, which meant we had to set it higher.

[apupier]

yes 1.4.0) means that we don't want to use higher version than 1.4.0 included.
my question was not about that. it was why we put an upper restriction for the bpmn2 modeler plugins? We had some issues with these plugins previously? They were breaking APIs often?

[bfitzpat]

Usually a particular version is only going to work with a particular release of Eclipse, so it's more to keep in line with the version range we know will support Oxygen or Neon or whatever is next I suspect. @pleacu do you have a better answer?

[apupier]

it's standard when changing major versions, not minor between 1.19 and 1.20 there should be no API break in theory.
but anyway I think that we are using specific target platform to avoid this kind of issue. That's fine.

[pleacu]

That's correct - you really don't want an unbounded version if for no other reason it makes you (developers) re-examine the dependent jar every one in a while. Given its bpmn2 we clearly know more about the dependency but it's really standard operating procedure.

…

--paull

On Tue, Apr 11, 2017 at 10:00 AM, Brian Fitzpatrick < ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In eclipse/plugins/org.switchyard.tools.ui.bpmn2/META-INF/MANIFEST.MF <#658 (comment)> : > @@ -21,9 +21,9 @@ Require-Bundle: org.eclipse.ui, org.eclipse.emf.edit.ui, org.eclipse.emf.transaction, org.eclipse.bpmn2, - org.eclipse.bpmn2.modeler.core;bundle-version="[1.1.0,1.4.0)", - org.eclipse.bpmn2.modeler.ui;bundle-version="[1.1.0,1.4.0)", - org.eclipse.bpmn2.modeler.runtime.jboss.jbpm;bundle-version="[1.2.3,1.4.0)", + org.eclipse.bpmn2.modeler.core;bundle-version="[1.1.0,1.5.0)", Usually a particular version is only going to work with a particular release of Eclipse, so it's more to keep in line with the version range we know will support Oxygen or Neon or whatever is next I suspect. @pleacu <https://github.com/pleacu> do you have a better answer? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#658 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC1-LQz4mcrB4A9FjyM8cOhm1D2k01M0ks5ru4d2gaJpZM4M3cJd> .