[2.4] Add Duration-based setKeepAliveTime API to 2.4.x for Infinispan 15.0.… #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhusar
changed the title
Member
|
Would it be OK to release this as a 2.5.0? |
|
@dmlloyd A 2.5.0 release is fine. |
Member
|
Can I require Java 17 as a baseline? Or should it work with 11? |
Member
|
Rebased on to 2.x. Beware because the branch is still called 2.4! |
Author
|
OK this will need a rebase then. |
Author
Yes. This is for EAP 8.1.1 which is JDK 17 baselined. |
…x compatibility This commit adds java.time.Duration overloads for setKeepAliveTime methods to resolve API incompatibility between jboss-threads 2.4.x and Infinispan 15.0.19+. Infinispan 15.0.19 (from RHDG 8.5.5) calls: builder.setKeepAliveTime(Duration.of(keepAlive, ChronoUnit.MILLIS)) But jboss-threads 2.4.0 only provides: setKeepAliveTime(long, TimeUnnit) resulting in NoSuchMethodError Signed-off-by: Radoslav Husar <radosoft@gmail.com>
Member
|
The linux test doesn't fail for me locally on Linux (or anything else) so I'll just go ahead with this for now. |
dmlloyd
approved these changes
Nov 18, 2025
Author
|
Looks like those tests are flaky, especially on GHA... |
Author
|
Thanks for the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…x compatibility
This commit adds java.time.Duration overloads for setKeepAliveTime methods to resolve API incompatibility between jboss-threads 2.4.x and Infinispan 15.0.19+.
Infinispan 15.0.19 (from RHDG 8.5.5) calls:
builder.setKeepAliveTime(Duration.of(keepAlive, ChronoUnit.MILLIS))
But jboss-threads 2.4.0 only provides:
setKeepAliveTime(long, TimeUnnit)
resulting in NoSuchMethodError