Increase project description limit to 1000 characters#231
Increase project description limit to 1000 characters#231peripheralist merged 7 commits intojbx-protocol:mainfrom aeolianeth:aeolianeth/increase-project-description-limit
Conversation
|
|
||
| <div style={{ flex: 1 }}> | ||
| <h1 | ||
| <div |
There was a problem hiding this comment.
Here, we're moving the h1 and the project id under the same div. This way, we have more control over the project description layout
|
@peripheralist 👋 , mind taking a look at this one when you have a chance? P.s. let me know how we should request reviews and who to ask 🙂 |
|
@aeolianeth looking great, thanks for including the before/after pictures! what do you think about also finding a way to show max 3-4 lines on the project page, with a "show more" option to expand it to show the rest? if a project does actually use a 1000 char description, it would be nice for it to not always be taking up so much space |
|
@peripheralist totally agree! To keep the PR small, I'm happy to add this in a follow-up PR. WDYT? |
Let's try to get this UI improvement included here. That way if anyone updates their description to be real long before we get another PR done, it'll look nice right off the bat 😄 Looks like Antd includes a |
|
@peripheralist, totally, good call 🙏 I've created a new component I had to update Let me know what you think! |
|
love it @aeolianeth ! this works great. what do you think about moving the ProjectDescription component under shared/ as a more generic "Paragraph.tsx" component, where the maxLength could be passed in to also, i wouldn't mind leaving out the little arrow icon—i wonder if it draws more attention to the toggle button than it needs |
Here, we ensure that the project description is the full width of the device on mobile. We achieve this by: - Moving the project id/settings section and the h1 into the same div. - Setting a max-width on the project description. 700px is the recommended width for most efficient reading of text
This component includes logic for expanding and contracting long descriptions.
Love this idea - done! Here's a screenshot, (i didn't update the demo video in the description:)
|
|
yes! awesome work, thank you |
2 participants
Fixes #175
Screenshots
With long descriptions
long-descr.mp4