Skip to content

Conversation

@seriouszyx
Copy link
Contributor

@seriouszyx seriouszyx commented Oct 27, 2021

Fix: #11

@casbin-bot
Copy link

@tangyang9464 @elfisworking @fangzhengjin please review

@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #20 (d2db686) into master (52ee85d) will increase coverage by 4.89%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   82.60%   87.50%   +4.89%     
==========================================
  Files           3        3              
  Lines          46       48       +2     
  Branches        3        3              
==========================================
+ Hits           38       42       +4     
+ Misses          6        3       -3     
- Partials        2        3       +1     
Impacted Files Coverage Δ
src/main/java/org/casbin/watcher/RedisWatcher.java 90.90% <100.00%> (+0.90%) ⬆️
src/main/java/org/casbin/watcher/SubThread.java 86.66% <0.00%> (+13.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52ee85d...d2db686. Read the comment docs.

@casbin-bot
Copy link

@tangyang9464 @elfisworking @fangzhengjin please review

@hsluoyz
Copy link
Member

hsluoyz commented Oct 27, 2021

@rongfengliang plz review

@elfisworking
Copy link
Member

@seriouszyx using git rebase to merge two commit into one commit . That's better

@seriouszyx
Copy link
Contributor Author

changed

@hsluoyz
Copy link
Member

hsluoyz commented Nov 1, 2021

@seriouszyx plz fix:

image

Signed-off-by: “seriouszyx” <seriouszyx@foxmail.com>
@hsluoyz
Copy link
Member

hsluoyz commented Nov 3, 2021

@seriouszyx can you also add this to the README as a new example? https://github.com/jcasbin/redis-watcher#simple-example

Signed-off-by: “seriouszyx” <seriouszyx@foxmail.com>
@seriouszyx
Copy link
Contributor Author

@hsluoyz done

@hsluoyz hsluoyz merged commit c81ed92 into jcasbin:master Nov 3, 2021
@hsluoyz
Copy link
Member

hsluoyz commented Nov 3, 2021

lgtm

@github-actions
Copy link

github-actions bot commented Nov 3, 2021

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add connect redis with password

4 participants