Skip to content

docs: expand devcontainer host vagrant architecture canvas#246

Merged
2-Coatl merged 2 commits intodevelopfrom
feature/create-improvement-plan-for-.devcontainer-09-30-02
Nov 18, 2025
Merged

docs: expand devcontainer host vagrant architecture canvas#246
2-Coatl merged 2 commits intodevelopfrom
feature/create-improvement-plan-for-.devcontainer-09-30-02

Conversation

@2-Coatl
Copy link
Copy Markdown
Collaborator

@2-Coatl 2-Coatl commented Nov 18, 2025

Summary

  • refresh the DevContainer Host with Vagrant canvas to emphasize running containers only inside the VM and add code examples
  • document quality objectives, risks, and implementation checklist aligned to the Docker-less workstation constraint
  • update the architecture index entry to reference the new canvas scope

Testing

  • not run (documentation-only change)

Codex Task

Copilot AI review requested due to automatic review settings November 18, 2025 09:30
@2-Coatl 2-Coatl merged commit a3f2458 into develop Nov 18, 2025
6 of 29 checks passed
@chatgpt-codex-connector
Copy link
Copy Markdown

💡 Codex Review

https://github.com/2-Coatl/IACT---project/blob/bf2c6e761c1d262d8b7b92ccd1ac0c86d4dc813a/infrastructure/devcontainer/scripts/init_host.sh#L272-L276
P1 Badge Create devcontainer .env even when app env already exists

In setup_env_file the early return on lines 272‑276 exits as soon as api/callcentersite/env exists, so the new block that copies .devcontainer/.env.example to .devcontainer/.env never runs for existing checkouts. On an upgrade path (most developers already have api/callcentersite/env), the devcontainer compose now references .devcontainer/.env as a required env_file but the host script will not create it, causing docker compose to fail with “.env: no such file or directory” until users manually create it. The return should not short-circuit the devcontainer env creation.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@2-Coatl 2-Coatl deleted the feature/create-improvement-plan-for-.devcontainer-09-30-02 branch November 18, 2025 09:37
@2-Coatl 2-Coatl review requested due to automatic review settings March 23, 2026 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant