This repository was archived by the owner on Nov 16, 2022. It is now read-only.
Add Built In Customization #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Has HTML file for I/O and a JS file to enter cookies
Removed duplicate Date(); calls to allow better debugging. HTML fixes Added proper counters
EKKOING
commented
Aug 26, 2019
README.md
Outdated
| The design of version 2 was inspired by [Decount](https://decount.co/) (and this design was reimplemented into Decount), and the original source code was adapted from [Eric Li's Network Clock](https://github.com/eli8527/Network-Clock). | ||
|
|
||
| CClock © 2019, Jiahua Chen. Released under the [MIT License](https://mit-license.org/). | ||
| CClock © 2019, [Jiahua Chen](github.com/jiahuac) & [Nicholas Lorentzen](github.com/EKKOING). Released under the [MIT License](https://mit-license.org/). |
Author
There was a problem hiding this comment.
I should probably get a mention.
EKKOING
commented
Aug 26, 2019
| currentSchedule[0] = new Period("Period 1", 8, 30, 9, 15); | ||
| ``` | ||
| Where `new Period("Period 1", 8, 30, 9, 15)` means that the first period of the day (in `currentSchedule[0]`) is called "Period 1", and it starts at 8:30 AM and ends at 9:15 AM. The rest of the periods, and the rest of the days are defined similarly. | ||
| //NEEDS TO BE REWRITTEN TO SPECIFY 2 WAYS OF CUSTOMIZATION |
Author
There was a problem hiding this comment.
Suggested change
| //NEEDS TO BE REWRITTEN TO SPECIFY 2 WAYS OF CUSTOMIZATION |
Will be rewritten once I'm not committing at 2am
Author
|
Fixed Bugs I found in my personal testing. You can test the functionality at https://ekkoing.github.io/cclock/ and https://ekkoing.github.io/cclock/scheduler |
EKKOING
commented
Aug 26, 2019
Corona Clock Current Period View
Now warns the user if they try to fill out both 5A and 5B slots for a given day.
Decount has made a claim that Jiahua Chen was an employee when he created this design and as a result had no right to release it under an MIT license. As I have gotten tired of hearing them argue with Jiahua, I have generously offered to put this little message in exchange for their silence. This in no way means that I believe their claims, but rather don't have any interest in continuing the debate.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the functionality of The Record's Webclock's Customization Tool through cookies.
The customizer needs a style upgrade but should be fully functional once the domain tag on the scheduler.js file is set correctly. (AKA replace ekkoing.github.io with hotchkissclock.com)
The main clock page is already compatible due to an unobtrusive function that does not disturb the majority of the original code and to keep stuff as simple as possible.
-NL