This repository was archived by the owner on Feb 4, 2019. It is now read-only.
Minor changes to compute-basics after code review #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
Perhaps the comment could better be "for GCE, the credential parameter is the path to the private key file"?
Member
|
Thanks, @suriyapriya! The changes in this PR itself are fine (I've only made one minor comment), but I think there are a couple of other things in the docs we are modifying that you might like to fix too? |
Minor changes
Contributor
Author
|
@demobox Fixed the minor comments and squashed the changes. Thanks, |
Member
|
Committed to master. Thanks, @suriyapriya! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed all the comments mentioned in the previous PR.
#34
Thanks,
Suriya