This repository was archived by the owner on Feb 4, 2019. It is now read-only.
Fixes to Cloud Files examples from PR #50#51
Closed
etoews wants to merge 1 commit intojclouds:masterfrom
Closed
Conversation
Member
There was a problem hiding this comment.
According to the [Javadoc for writeFrom](http://docs.guava-libraries.googlecode.com/git/javadoc/com/google/common/io/ByteSink.html#writeFrom(java.io.InputStream\)), it does not close the input stream.
@andrewgaul @everett-toews: is that OK?
Member
Author
There was a problem hiding this comment.
@demobox Good catch. Fixed. I explicitly release the payload.
Member
|
One comment about streams. Otherwise, looks good to me. Thanks, @everett-toews! |
Member
Author
|
Confirmed that this fixes the static website issue for the jclouds-site-staging Jenkins job. |
Member
Author
|
Merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continue from #50