Skip to content
This repository was archived by the owner on Feb 4, 2019. It is now read-only.

Conversation

@najtmar
Copy link
Contributor

@najtmar najtmar commented Jul 30, 2014

No description provided.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script builder shouldn't be used directly. Change this to just Statement script = Statements.exec("ls -l /") and pass directly the Statement object to the runScriptOnNode method?
This way jclouds will automatically render it based on the node operating system type. There's no need to manually render the statement.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@demobox
Copy link
Member

demobox commented Aug 1, 2014

+1 - looks good to me. Thanks, @najtmar! Could you squash this down to one commit?

@najtmar
Copy link
Contributor Author

najtmar commented Aug 4, 2014

Squashed down to one commit.

@demobox
Copy link
Member

demobox commented Aug 4, 2014

Committed to master. Thanks, @najtmar!

@demobox demobox closed this Aug 4, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants