Skip to content
This repository was archived by the owner on Feb 4, 2019. It is now read-only.

Make CreateServer allow a user to execute jobs via SSH.#59

Closed
najtmar wants to merge 1 commit intojclouds:masterfrom
najtmar:master
Closed

Make CreateServer allow a user to execute jobs via SSH.#59
najtmar wants to merge 1 commit intojclouds:masterfrom
najtmar:master

Conversation

@najtmar
Copy link
Copy Markdown
Contributor

@najtmar najtmar commented Aug 11, 2014

No description provided.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these the credentials to be used to log in to the target machine? Do we need to add a comment saying something like "your private key will not be transmitted anywhere"?

Also, what is the PEM for, in this case? Just to authenticate commands to the service? Would it be possible to use that PEM also to log into the target box, or is that not recommended?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added clarifying comments and a disclaimer that private keys are not transmitted anywhere.

The experience I gained when writing this example (and the way I understand the documentation) tell me that we need the PEM file for server-to-server interaction and the SSH keys to perform actions on machines.

@demobox
Copy link
Copy Markdown
Member

demobox commented Aug 12, 2014

Checkstyle recommended me to do this. Reverted.

If Checkstyle recommended it, please put it back - we try to stick to Checkstyle generally.

Thanks for the other updates, @najtmar. With this last change, looks good to me!

@demobox
Copy link
Copy Markdown
Member

demobox commented Aug 12, 2014

+1 - looks good to me! Could you squash'n'rebase? Then we should be good to merge!

@najtmar
Copy link
Copy Markdown
Contributor Author

najtmar commented Aug 12, 2014

Rebased and squashed.

@demobox
Copy link
Copy Markdown
Member

demobox commented Aug 12, 2014

Committed to master. Thanks, @najtmar!

@demobox demobox closed this Aug 12, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants