Make CreateServer allow a user to execute jobs via SSH.#59
Make CreateServer allow a user to execute jobs via SSH.#59najtmar wants to merge 1 commit intojclouds:masterfrom
Conversation
There was a problem hiding this comment.
Are these the credentials to be used to log in to the target machine? Do we need to add a comment saying something like "your private key will not be transmitted anywhere"?
Also, what is the PEM for, in this case? Just to authenticate commands to the service? Would it be possible to use that PEM also to log into the target box, or is that not recommended?
There was a problem hiding this comment.
Added clarifying comments and a disclaimer that private keys are not transmitted anywhere.
The experience I gained when writing this example (and the way I understand the documentation) tell me that we need the PEM file for server-to-server interaction and the SSH keys to perform actions on machines.
If Checkstyle recommended it, please put it back - we try to stick to Checkstyle generally. Thanks for the other updates, @najtmar. With this last change, looks good to me! |
|
+1 - looks good to me! Could you squash'n'rebase? Then we should be good to merge! |
|
Rebased and squashed. |
No description provided.