Skip to content

feat: remove eslint-env comments in migrate script #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jedwards1211 merged 4 commits into from
Feb 13, 2026
Merged

feat: remove eslint-env comments in migrate script #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0525957
chore: wip on eslint 10
jedwards1211 Feb 13, 2026
8a44177
feat: remove eslint-env comments in migrate script
jedwards1211 Feb 13, 2026
19715a3
fix: add entries to eslint.config.cjs for migrated eslint-env comments
jedwards1211 Feb 13, 2026
134d548
chore: fix eslint error
jedwards1211 Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ orbs:
jobs:
build:
docker:
- image: cimg/node:20.10.0
- image: cimg/node:20.19.0

steps:
- checkout
Expand Down
1 change: 1 addition & 0 deletions eslint.config.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ module.exports = defineConfig([
{
files: ['packages/**/*.{js,cjs,mjs}'],
languageOptions: {
ecmaVersion: 2020,
globals: {
...globals.node,
...globals.es2018,
Expand Down
1 change: 0 additions & 1 deletion fixtures/async-throttle/init-snapshot/.babelrc.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-env node, es2018 */
module.exports = function (api) {
const base = require('@jcoreio/toolchain-esnext/.babelrc.cjs')(api)
return {
Expand Down
1 change: 0 additions & 1 deletion fixtures/async-throttle/init-snapshot/.mocharc.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-env node, es2018 */
const base = require('@jcoreio/toolchain-mocha/.mocharc.cjs')
const { getSpecs } = require('@jcoreio/toolchain-mocha')
module.exports = {
Expand Down
1 change: 0 additions & 1 deletion fixtures/async-throttle/init-snapshot/_lint-staged.config.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-env node, es2018 */
const base = require('@jcoreio/toolchain/lint-staged.config.cjs')
module.exports = {
...base,
Expand Down
8 changes: 4 additions & 4 deletions fixtures/async-throttle/init-snapshot/dist/pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions fixtures/async-throttle/init-snapshot/eslint.config.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,10 @@ module.exports = defineConfig([
},
},
},
{
files: ['test/configure.js', 'test/clearConsole.js'],
languageOptions: {
globals: globals.node,
},
},
])
1 change: 0 additions & 1 deletion fixtures/async-throttle/init-snapshot/githooks.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-env node, es2018 */
const base = require('@jcoreio/toolchain/githooks.cjs')
module.exports = {
...base,
Expand Down
1 change: 0 additions & 1 deletion fixtures/async-throttle/init-snapshot/nyc.config.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-env node, es2018 */
const base = require('@jcoreio/toolchain-mocha/nyc.config.cjs')
module.exports = {
...base,
Expand Down
8 changes: 4 additions & 4 deletions fixtures/async-throttle/init-snapshot/pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion fixtures/async-throttle/init-snapshot/prettier.config.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-env node, es2018 */
const base = require('@jcoreio/toolchain/prettierConfig.cjs')
module.exports = {
...base,
Expand Down
1 change: 0 additions & 1 deletion fixtures/async-throttle/init-snapshot/release.config.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-env node, es2018 */
module.exports = {
extends: [
require.resolve('@jcoreio/toolchain-semantic-release/release.config.cjs'),
Expand Down
2 changes: 0 additions & 2 deletions fixtures/async-throttle/init-snapshot/test/clearConsole.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
/* eslint-env node */

if (process.argv.indexOf('--watch') >= 0) {
before(() => process.stdout.write('\u001b[2J\u001b[1;1H\u001b[3J'))
}
2 changes: 0 additions & 2 deletions fixtures/async-throttle/init-snapshot/test/configure.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
/* eslint-env node */

if (process.argv.indexOf('--watch') >= 0) {
before(() => process.stdout.write('\u001b[2J\u001b[1;1H\u001b[3J'))
}
1 change: 0 additions & 1 deletion fixtures/async-throttle/init-snapshot/toolchain.config.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-env node, es2018 */
module.exports = {
cjsBabelEnv: { targets: { node: 16 } },
esmBabelEnv: { targets: { node: 16 } },
Expand Down
1 change: 0 additions & 1 deletion fixtures/async-throttle/upgrade-snapshot/_lint-staged.config.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-env node, es2018 */
const base = require('@jcoreio/toolchain/lint-staged.config.cjs')
module.exports = {
...base,
Expand Down
24 changes: 12 additions & 12 deletions fixtures/async-throttle/upgrade-snapshot/dist/pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions fixtures/async-throttle/upgrade-snapshot/eslint.config.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,10 @@ module.exports = defineConfig([
},
},
},
{
files: ['test/clearConsole.js'],
languageOptions: {
globals: globals.node,
},
},
])
1 change: 0 additions & 1 deletion fixtures/async-throttle/upgrade-snapshot/githooks.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-env node, es2018 */
const base = require('@jcoreio/toolchain/githooks.cjs')
module.exports = {
...base,
Expand Down
1 change: 0 additions & 1 deletion fixtures/async-throttle/upgrade-snapshot/nyc.config.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-env node, es2018 */
const base = require('@jcoreio/toolchain-mocha/nyc.config.cjs')
module.exports = {
...base,
Expand Down
24 changes: 12 additions & 12 deletions fixtures/async-throttle/upgrade-snapshot/pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion fixtures/async-throttle/upgrade-snapshot/prettier.config.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-env node, es2018 */
const base = require('@jcoreio/toolchain/prettierConfig.cjs')
module.exports = {
...base,
Expand Down
1 change: 0 additions & 1 deletion fixtures/async-throttle/upgrade-snapshot/release.config.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-env node, es2018 */
module.exports = {
extends: [
require.resolve('@jcoreio/toolchain-semantic-release/release.config.cjs'),
Expand Down
2 changes: 0 additions & 2 deletions fixtures/async-throttle/upgrade-snapshot/test/clearConsole.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
/* eslint-env node */

if (process.argv.indexOf('--watch') >= 0) {
before(() => process.stdout.write('\u001b[2J\u001b[1;1H\u001b[3J'))
}
1 change: 0 additions & 1 deletion fixtures/async-throttle/upgrade-snapshot/toolchain.config.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-env node, es2018 */
module.exports = {
cjsBabelEnv: { targets: { node: 16 } },
esmBabelEnv: { targets: { node: 16 } },
Expand Down
1 change: 0 additions & 1 deletion fixtures/find-cycle/init-snapshot/.mocharc.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-env node, es2018 */
const base = require('@jcoreio/toolchain-mocha/.mocharc.cjs')
const { getSpecs } = require('@jcoreio/toolchain-mocha')
module.exports = {
Expand Down
1 change: 0 additions & 1 deletion fixtures/find-cycle/init-snapshot/_lint-staged.config.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-env node, es2018 */
const base = require('@jcoreio/toolchain/lint-staged.config.cjs')
module.exports = {
...base,
Expand Down
Loading