ci(depcheck): switch to Dependency-Check_Action wrapper#12
Merged
Conversation
Mirror ratchet's approach. The Maven plugin path was forced to cold- download the full ~350k-record NVD dataset on every fresh runner, which even with NVD_API_KEY takes several minutes and previously timed out the 30-minute job slot on cache misses. The Dependency-Check_Action Docker image ships with a pre-warmed dataset baked in, so cold runs only fetch the daily delta and finish in 1.5-5 minutes (validated against ratchet). Workflow changes: - Replace `mvn -P security verify` invocation with the GHA wrapper. - Drop the ISO-week NVD cache step (no longer relevant — data lives in the Docker image, not on the runner filesystem). - Drop the 30-minute timeout; default GitHub job timeout is fine now. - Disable OssIndex (Sonatype auth-token required since Sep 2025) and the JS-ecosystem analyzers (nothing to scan in a Java repo). - Compile-before-scan step (`mvn -DskipTests install`) populates ~/.m2 and module target/ JARs so the CLI walks the full resolved graph. pom.xml security profile stays for `mvn -P security verify` local use, with `<ossindexAnalyzerEnabled>false</ossindexAnalyzerEnabled>` added so local runs match CI behavior. Stale comments about CI cache layout were updated to reflect that CI no longer uses this path.
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dependency-check/Dependency-Check_Action@main, mirroring ratchet. The Action's Docker image ships with a pre-warmed NVD dataset, so cold runs only fetch the daily delta instead of the full ~350k records.pom.xmlsecurity profile stays for localmvn -P security verify, with<ossindexAnalyzerEnabled>false</ossindexAnalyzerEnabled>added for local/CI parity.Expected scan duration after this lands
~1.5–5 minutes on ubuntu-latest (per ratchet's recent runs), vs. the 30-min timeout cliff on the previous Maven plugin path.
Test plan
Dependency-Checkworkflow run on this PR's push to branch (manualworkflow_dispatchsince the workflow no longer triggers on PRs)