ci(depcheck): narrow scan to runtime closure#13
Merged
Conversation
…noise The Dependency-Check_Action wrapper with `path: '.'` was scanning the whole workspace post-`mvn install`, which includes target/local-repo materialized by maven-invoker-plugin for integration tests. That tree contains build-time Maven plugin transitives (plexus-utils 4.0.2, aircompressor 0.27) that never ship to consumers but trip the failOnCVSS=7 gate. Empirical check: every relevant plugin's latest version still pins the same vulnerable transitives, so upgrading plugins doesn't resolve the finding — it's a scope problem, not a version problem. Switch to `dependency:copy-dependencies -DincludeScope=runtime` per module to materialize only the runtime closure into target/depcheck-deps, then `--scan` exactly those two directories. The magika-java library JAR itself is reached transitively via magika-java-tika's depcheck-deps, so no version-pinned paths are needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Dependency-Check_Action wrapper with `path: '.'` over-scans the workspace post-`mvn install`. `target/local-repo` (populated by maven-invoker-plugin for IT tests) contains build-time Maven plugin transitives — `plexus-utils 4.0.2` (CVSS 8.8) and `aircompressor 0.27` (CVSS 6.3) — that never ship to consumers but trip the `failOnCVSS=7` gate.
Empirical confirmation that this is a scope problem, not a version problem:
No plugin bump fixes these.
Approach
Use `mvn dependency:copy-dependencies -DincludeScope=runtime -DoutputDirectory=target/depcheck-deps` per module. This materializes only the runtime closure (jackson, slf4j, onnxruntime, tika-core, commons-io, magika-java itself) into a dedicated dir. Then `--scan` exactly those two directories. The library JAR is reached transitively via magika-java-tika's depcheck-deps, so no version-pinned paths are needed.
Test plan