Skip to content

Drop Python 3.9#956

Merged
ofek merged 3 commits intojcrist:mainfrom
jacopoabramo:drop-39-take2
Nov 27, 2025
Merged

Drop Python 3.9#956
ofek merged 3 commits intojcrist:mainfrom
jacopoabramo:drop-39-take2

Conversation

@jacopoabramo
Copy link
Contributor

@jacopoabramo jacopoabramo commented Nov 25, 2025

Second attempt after #954

Closes #904

  • Remove .pytest.ini
  • Remove references to 3.9 in CI
  • Use hooks to autoformat imports in kv.py
  • Remove dependency on eval-type-backport for < 3.10
  • Remove PY310_PLUS check

@jacopoabramo
Copy link
Contributor Author

I don't think the falling test is due to this PR, right?

@ofek
Copy link
Collaborator

ofek commented Nov 26, 2025

Indeed, it looks like uv is downloading the wrong Python for that architecture. I'll look into that tonight.

@ofek
Copy link
Collaborator

ofek commented Nov 27, 2025

#959

@jacopoabramo
Copy link
Contributor Author

@ofek it is a bit annoying that PRs require approval for executing the CI/CD workflows. I can understand this is a safety measure (don't really know why but I can appreciate the need for harder security). Do you think that this could be changed at some point? It would be useful for PRs to automatically run the tests suite to check whether there's a fail in the tests or not, and would help you catch a glimpse of possible failures yourself (as in the case of #954 where I abruptly closed the PR - which now I regret but what can one do).

@ofek
Copy link
Collaborator

ofek commented Nov 27, 2025

I think CI runs automatically after someone's first PR is merged. I'm not an admin so I couldn't change the setting but I'll reach out to Jim about that.

@jacopoabramo
Copy link
Contributor Author

I think CI runs automatically after someone's first PR is merged

Ah, if that's the case I can live with that!

Copy link
Collaborator

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ofek
Copy link
Collaborator

ofek commented Nov 27, 2025

as in the case of #954 where I abruptly closed the PR - which now I regret but what can one do

Feel free to reopen and get to the bottom of what's going on there, I'm quite curious as well!

@ofek ofek changed the title Drop Python 3.9 - take 2 Drop Python 3.9 Nov 27, 2025
@ofek ofek merged commit a9ed8f1 into jcrist:main Nov 27, 2025
22 checks passed
@jacopoabramo
Copy link
Contributor Author

Feel free to reopen and get to the bottom of what's going on there, I'm quite curious as well!

I will; I have to try and find some time where I can make a reasonable investigation but I'll get back to it at some point.

@jacopoabramo jacopoabramo deleted the drop-39-take2 branch November 27, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop support for 3.9?

2 participants