This repository was archived by the owner on Oct 14, 2021. It is now read-only.
add tools and services query class#69
Open
sliu008 wants to merge 4 commits intojddeal:masterfrom
sliu008:toolsandservices
Open
add tools and services query class#69sliu008 wants to merge 4 commits intojddeal:masterfrom sliu008:toolsandservices
sliu008 wants to merge 4 commits intojddeal:masterfrom
sliu008:toolsandservices
Conversation
sliu008
commented
Oct 7, 2021
- Add in tools and service cmr query classes to query umm-t and umm-s.
- Change the base query class to be more generic and created a GranuleCollectionBaseQuery and ToolServiceBaseQuery classes.
- Add in more parameters to query by provider, native id, and name.
- Made concept id query more generic for each classes.
- Added test cases for new tools query and service query classes.
… tests for tools and services query
|
This is great! I was able to checkout your PR and run the unit tests successfully. Were you able to get live results after applying your changes? I've installed your PR changes locally but when I try doing: I get back 0 results. Also, maybe a quick addition of examples to the readme would help |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.