Add jupyter-book and jupyter to setup.py#40
Merged
jdebacker merged 4 commits intojdebacker:ethfrom Nov 10, 2025
Merged
Conversation
Author
|
@jdebacker. My most recent commit sets the version of |
jdebacker
reviewed
Nov 10, 2025
jdebacker
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jdebacker. I think this might fix the error we are getting in the GitHub action for building the docs. There is sometimes a difference between the conda environment (
ogcore-dev) and the packages that get installed from PyPI.org (pip install ogcore, fromsetup.py). The goal of this PR is to add thejupyterandjupyter-bookpackages as components of the PyPI.orgogcorepackage.Review and merge this and see if this fixes the GitHub Action. I can't really test this locally on my machine.