Skip to content
This repository was archived by the owner on Dec 20, 2021. It is now read-only.

Conversation

@hello-smile6
Copy link
Contributor

I have tested locally.

@imdevarsh
Copy link
Contributor

Hey, the actions workflow hasn't been tested and is in beta

@hello-smile6
Copy link
Contributor Author

Hey, the actions workflow hasn't been tested and is in beta

Then let's make it a draft PR.

@hello-smile6 hello-smile6 marked this pull request as draft December 8, 2021 21:32
@jdev082
Copy link
Owner

jdev082 commented Dec 8, 2021

what is "repo sync"

@imdevarsh
Copy link
Contributor

Adds the changes in hello-smile6 fork to this repository.

@jdev082
Copy link
Owner

jdev082 commented Dec 8, 2021

webload.html was renamed to index.html a while back

@hello-smile6
Copy link
Contributor Author

webload.html was renamed to index.html a while back

Okay, I'll fix that.

@hello-smile6 hello-smile6 marked this pull request as ready for review December 8, 2021 23:35
@jdev082
Copy link
Owner

jdev082 commented Dec 8, 2021

a check has failed. try running 'npm run check' in your code and run the formatter commands

@jdev082
Copy link
Owner

jdev082 commented Dec 8, 2021

please remove anything related to moving all the code to /, as I have already sorted out the problem.

@jdev082
Copy link
Owner

jdev082 commented Dec 8, 2021

all the changes of this PR have since already been applied, closing.

@jdev082 jdev082 closed this Dec 8, 2021
@hello-smile6
Copy link
Contributor Author

please remove anything related to moving all the code to /, as I have already sorted out the problem.

Okay, I merged that. There's no changes. I'll format it.

@imdevarsh
Copy link
Contributor

a check has failed. try running 'npm run check' in your code and run the formatter commands

It was because you didn't change the CI to fit changing the package.json, my PR does that.

@hello-smile6
Copy link
Contributor Author

all the changes of this PR have since already been applied, closing.

Actually, they have not. Look again.

@jdev082
Copy link
Owner

jdev082 commented Dec 9, 2021

this better not break anything...

@jdev082 jdev082 reopened this Dec 9, 2021
@jdev082
Copy link
Owner

jdev082 commented Dec 9, 2021

conflicts...

@imdevarsh
Copy link
Contributor

imdevarsh commented Dec 9, 2021

Which conflicts are there? I can try to solve them...

@jdev082
Copy link
Owner

jdev082 commented Dec 9, 2021

app/package-lock.json
app/package.json

@imdevarsh
Copy link
Contributor

app/package-lock.json app/package.json

I can't see them as I am not @hello-smile6 or @JaydenDev unfortunately.

@jdev082
Copy link
Owner

jdev082 commented Dec 9, 2021

i never gave hello-smile6 any special permissions...

@imdevarsh
Copy link
Contributor

@hello-smile6 made this PR.

@imdevarsh
Copy link
Contributor

Woohooo!

@hello-smile6
Copy link
Contributor Author

Fixed.

@ninjamar
Copy link
Contributor

ninjamar commented Dec 9, 2021

Can you add me into the contributors section? I just had a PR that got merged (#45 )

@jdev082
Copy link
Owner

jdev082 commented Dec 9, 2021

added you as a collaborator, accept the invite and see if that helps

@hello-smile6
Copy link
Contributor Author

I'll fix it!

@jdev082 jdev082 merged commit d1b86d4 into jdev082:main Dec 9, 2021
@imdevarsh
Copy link
Contributor

imdevarsh commented Dec 9, 2021

Checks failed! Checks failed! Please check the Actions workflow!!!!!

@ninjamar
Copy link
Contributor

ninjamar commented Dec 9, 2021

added you as a collaborator, accept the invite and see if that helps

i don't see an invite

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants