Skip to content

Conversation

@webdev03
Copy link
Contributor

@webdev03 webdev03 commented Feb 20, 2022

  • Adds const instead of let/var
  • Remove google forms link
  • Make search bar fill screen
  • Structure warnings CSS
  • Remove console.log which I left in Add search #13 by accident
  • Remove the body selector (doesn't do anything, in svelte it is scoped)
  • Remove the fakecommit file (use --allow-empty instead)

Fixes #15 (but what does the first thing mean?)

@vercel
Copy link

vercel bot commented Feb 20, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/jaydendev/wininfo/HwHGyUKn9Ex6bW3WkAsNSM6feSr6
✅ Preview: https://wininfo-git-fork-webdev03-optimisations-jaydendev.vercel.app

@jdev082
Copy link
Owner

jdev082 commented Feb 20, 2022

--allow-empty cannot be used when I make quick changes in GitHub itself and want to test the auto release thingy

@jdev082
Copy link
Owner

jdev082 commented Feb 20, 2022

Also at one point, the card holding all the OS's took full screen width, are you using the latest source in your PR?

@jdev082
Copy link
Owner

jdev082 commented Feb 20, 2022

This PR appears finished. Are you going to mark it ready?

@kccuber-scratch
Copy link

Why is everything so clumped together? It looks like it was made to be used on an iPad in vertical orientation.

@webdev03
Copy link
Contributor Author

Oh right!! I know!

Why is everything so clumped together? It looks like it was made to be used on an iPad in vertical orientation.

Removed some width thing while trying to make it responsive. Sorry

@webdev03
Copy link
Contributor Author

This PR appears finished. Are you going to mark it ready?

I'm still working on it.. I'm not a worker for you I am just a volunteer

@webdev03 webdev03 mentioned this pull request Feb 21, 2022
@kccuber-scratch
Copy link

I think we should wait until #17 is merged before merging this as there's some conflicts (mainly the remove google form)

@webdev03
Copy link
Contributor Author

OK that's fine!

@webdev03 webdev03 closed this Feb 23, 2022
@webdev03 webdev03 reopened this Feb 24, 2022
@webdev03 webdev03 marked this pull request as ready for review February 24, 2022 03:49
@webdev03
Copy link
Contributor Author

ready

@jdev082 jdev082 merged commit b03cdd3 into jdev082:main Feb 24, 2022
@webdev03 webdev03 deleted the optimisations branch February 25, 2022 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Design Changes 19.2.2022

3 participants