-
Notifications
You must be signed in to change notification settings - Fork 4
Optimisations #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimisations #19
Conversation
(use --allow-empty instead please)
(you forgot a colon)
not allowed on scratch
const is better
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/jaydendev/wininfo/HwHGyUKn9Ex6bW3WkAsNSM6feSr6 |
|
--allow-empty cannot be used when I make quick changes in GitHub itself and want to test the auto release thingy |
|
Also at one point, the card holding all the OS's took full screen width, are you using the latest source in your PR? |
|
This PR appears finished. Are you going to mark it ready? |
|
Why is everything so clumped together? It looks like it was made to be used on an iPad in vertical orientation. |
|
Oh right!! I know!
Removed some width thing while trying to make it responsive. Sorry |
I'm still working on it.. I'm not a worker for you I am just a volunteer |
|
I think we should wait until #17 is merged before merging this as there's some conflicts (mainly the remove google form) |
|
OK that's fine! |
|
ready |
console.logwhich I left in Add search #13 by accidentfakecommitfile (use--allow-emptyinstead)Fixes #15 (but what does the first thing mean?)