Fix monitoring metrics format in provider guide#2
Merged
Conversation
The documented graphite path and metric set did not match the actual emission. Update the provider guide to describe: - the six-segment path including the user partition between command name and metric leaf - the four metric leaves (count, duration, ok, ko) as independent siblings rather than ok/ko compounds of count and duration - the nanosecond unit on duration - the three lines emitted per invocation
Fixes markdownlint MD040 (fenced-code-language) reported by the gh-pages CI lint job. The new code block in the Monitoring section of the provider guide was missing a language tag; using `text` to match the existing convention elsewhere in the file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Port of upstream PR criteo#198 onto the fork's main.
Two doc-only commits to
gh-pages/content/en/docs/overview/provider-guide.md:The original branch
fix-metrics-doc(which still backs PR criteo#198 upstream) is untouched.Test plan